fix(plugin-github): parse new style github urls (#1318)

* fix(plugin-github): parse new style github urls

Fixes #1317.

* chore(release-workflow): set releases

* refactor(plugin-github): extract commit using querystring

* refactor: make `parseGithubUrl` support both old style and new style urls

Author: paul-soporan

.yarn/versions/d8dd0ce4.yml

@@ -0,0 +1,31 @@
+releases:
+  "@yarnpkg/plugin-github": prerelease
+  "@yarnpkg/cli": prerelease
+
+declined:
+  - "@yarnpkg/plugin-compat"
+  - "@yarnpkg/plugin-constraints"
+  - "@yarnpkg/plugin-dlx"
+  - "@yarnpkg/plugin-essentials"
+  - "@yarnpkg/plugin-exec"
+  - "@yarnpkg/plugin-file"
+  - "@yarnpkg/plugin-git"
+  - "@yarnpkg/plugin-github"
+  - "@yarnpkg/plugin-http"
+  - "@yarnpkg/plugin-init"
+  - "@yarnpkg/plugin-interactive-tools"
+  - "@yarnpkg/plugin-link"
+  - "@yarnpkg/plugin-node-modules"
+  - "@yarnpkg/plugin-npm"
+  - "@yarnpkg/plugin-npm-cli"
+  - "@yarnpkg/plugin-pack"
+  - "@yarnpkg/plugin-patch"
+  - "@yarnpkg/plugin-pnp"
+  - "@yarnpkg/plugin-stage"
+  - "@yarnpkg/plugin-typescript"
+  - "@yarnpkg/plugin-version"
+  - "@yarnpkg/plugin-workspace-tools"
+  - "@yarnpkg/core"
+  - "@yarnpkg/builder"
+  - "@yarnpkg/doctor"
+  - "@yarnpkg/pnpify"

packages/acceptance-tests/pkg-tests-fixtures/index.js

@@ -1,3 +1,3 @@
-const {npath} = require('@yarnpkg/fslib');
+const {npath} = require(`@yarnpkg/fslib`);
 
 module.exports = npath.toPortablePath(__dirname);

packages/plugin-github/sources/githubUtils.ts

@@ -1,3 +1,5 @@
+import querystring from 'querystring';
+
 type ParsedGithubUrl = {
   auth?: string;
   username: string;
@@ -35,7 +37,17 @@ export function parseGithubUrl(urlStr: string): ParsedGithubUrl {
 
   let [, auth, username, reponame, treeish = `master`] = match;
 
-  treeish = treeish.replace(/[^:]*:/, ``);
+  const {commit} = querystring.parse(treeish) as {commit?: string};
+
+  treeish =
+    // New style:
+    // The URLs have already been normalized by `gitUtils.resolveUrl`,
+    // so it's certain in the context of the `GithubFetcher`
+    // that the `commit` querystring parameter exists
+    commit
+    // Old style:
+    // Shouldn't ever be needed by the GithubFetcher
+    || treeish.replace(/[^:]*:/, ``);
 
   return {auth, username, reponame, treeish};
 }

packages/plugin-github/tests/githubUtils.test.ts

@@ -21,6 +21,12 @@ const validScenarios = [{
 }, {
   url: `https://github.com/owner/repo.git#abcdef`,
   auth: undefined, username: `owner`, reponame: `repo`, treeish: `abcdef`,
+}, {
+  url: `https://github.com/owner/repo.git#commit=abcdef`,
+  auth: undefined, username: `owner`, reponame: `repo`, treeish: `abcdef`,
+}, {
+  url: `https://github.com/owner/repo.git#commit=abcdef&workspace=foobar`,
+  auth: undefined, username: `owner`, reponame: `repo`, treeish: `abcdef`,
 }];
 
 const invalidScenarios = [{