replacing invalid chars with underscores in env (#3687)

sudoarslan · arcanis · commit 23dd84b4ba2e · 2017-06-22T18:23:18.000+01:00
diff --git a/src/util/execute-lifecycle-script.js b/src/util/execute-lifecycle-script.js
@@ -79,7 +79,11 @@ export async function makeEnv(
         if (cleanVal.indexOf('\n') >= 0) {
           cleanVal = JSON.stringify(cleanVal);
         }
-        env[`npm_package_${key}`] = cleanVal;
+
+        //replacing invalid chars with underscore
+        const cleanKey = key.replace(/[^a-zA-Z0-9_]/g, '_');
+
+        env[`npm_package_${cleanKey}`] = cleanVal;
       }
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,11 @@ export async function makeEnv(`
`79`	`79`	`if (cleanVal.indexOf('\n') >= 0) {`
`80`	`80`	`cleanVal = JSON.stringify(cleanVal);`
`81`	`81`	`}`
`82`		- env[`npm_package_${key}`] = cleanVal;
	`82`	`+`
	`83`	`+ //replacing invalid chars with underscore`
	`84`	`+ const cleanKey = key.replace(/[^a-zA-Z0-9_]/g, '_');`
	`85`	`+`
	`86`	+ env[`npm_package_${cleanKey}`] = cleanVal;
`83`	`87`	`}`
`84`	`88`	`}`
`85`	`89`	`}`