Skip to content

Commit f69cdda

Browse files
dreykskaylieEB
authored and
kaylieEB
committed
fix(resolutions): Warn instead of erroring if unmatched dependency matches resolutions (#4835)
Summary Fixes #4825. When running yarn check do not error if the unmatched dependency matches the override in resolutions field of package.json. Just warn about the mismatch Test plan New test case added.
1 parent 02f7de6 commit f69cdda

File tree

14 files changed

+577
-1
lines changed

14 files changed

+577
-1
lines changed

__tests__/commands/check.js

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -351,6 +351,24 @@ test.concurrent('should ignore bundled dependencies', async (): Promise<void> =>
351351
);
352352
});
353353

354+
test.concurrent('should warn about mismatched dependencies if they match resolutions', async (): Promise<void> => {
355+
let mismatchError = false;
356+
let stdout = '';
357+
try {
358+
await runCheck([], {}, 'resolutions', (config, reporter, check, getStdout) => {
359+
stdout = getStdout();
360+
});
361+
} catch (err) {
362+
mismatchError = true;
363+
}
364+
expect(mismatchError).toEqual(false);
365+
expect(
366+
stdout.search(
367+
`warning.*"[email protected]" is incompatible with requested version "pad-left#repeat-string@\\^1.5.4"`,
368+
),
369+
).toBeGreaterThan(-1);
370+
});
371+
354372
test.concurrent('--integrity should throw an error if top level patterns do not match', async (): Promise<void> => {
355373
let integrityError = false;
356374
try {

__tests__/fixtures/check/resolutions/node_modules/.yarn-integrity

Lines changed: 18 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

__tests__/fixtures/check/resolutions/node_modules/pad-left/LICENSE

Lines changed: 21 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

__tests__/fixtures/check/resolutions/node_modules/pad-left/README.md

Lines changed: 134 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

__tests__/fixtures/check/resolutions/node_modules/pad-left/index.js

Lines changed: 28 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

__tests__/fixtures/check/resolutions/node_modules/pad-left/package.json

Lines changed: 88 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)