Skip to content

Compatibility #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tinywombat765 opened this issue Dec 24, 2017 · 5 comments
Closed

Compatibility #6

tinywombat765 opened this issue Dec 24, 2017 · 5 comments
Assignees

Comments

@tinywombat765
Copy link

It seems that this only builds on asmjs-unkown-emscripten in debug mode

@therustmonk
Copy link
Member

Thank you for this issue report. Right, It doesn't work for every target, but only for asmjs debug. While there are cases when even asmjs fails, like this one: rust-lang/rust#46730
I'm going to do it compatible with all targets. With your permission I will use this issue for tracking support of:

  • asmjs-unkown-emscripten - debug
  • asmjs-unkown-emscripten - release
  • wasm32-unknown-emscripten - debug
  • wasm32-unknown-emscripten - release
  • wasm32-unknown-unknown - debug
  • wasm32-unknown-unknown - release
  • add checks to TravisCI

Related: koute/stdweb#36

@therustmonk therustmonk self-assigned this Dec 25, 2017
@tinywombat765
Copy link
Author

tinywombat765 commented Dec 25, 2017 via email

@koute
Copy link
Contributor

koute commented Dec 26, 2017

The wasm32-unknown-unknown builds work (FYI, those are all release builds as rustc itself isn't able to properly do a debug build for that target yet), as do all of the debug *-emscripten ones. The Emscripten release builds check the generated .js file's syntax, which is why they fail.

You need to change this:

let callback = @{callback};

into this:

var callback = @{callback};

in html.rs#48

@therustmonk
Copy link
Member

@koute Thank you for the explanation! You've helped us to fix that.
Huge and Special Thanks for stdweb and carg-web! It's vital to this framework.

bors bot pushed a commit that referenced this issue Sep 26, 2019
@jstarry
Copy link
Member

jstarry commented Dec 10, 2019

Closing since asmjs-unkown-emscripten, wasm32-unknown-emscripten, and wasm32-unknown-unknown - debug have been supported for some time (debug and release)

@jstarry jstarry closed this as completed Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants