-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
phpspec/php-diff does not work correctly with utf-8 #3258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I can't reproduce it. Can you provide an example code? |
very strange behavior. for example |
Reproduced. I don't think it will be solved in any of sources we're using. Need to think about it... |
Since it's not critical I've set milestone to 2.1. If you have an idea how to fix it or want to try implementing diff properly let us know. Thanks! |
@yoopy have/can you tested/test it with this (not merged) pull request for php-diff: phpspec/php-diff#5 ? |
We can consider switching to https://github.com/yetanotherape/diff-match-patch |
phpspec/php-diff#5 is merged now and contained in release 1.1.0. can we close this? |
Issue moved to yiisoft/yii2-gii#147 |
for example, if a line has some russian vowels ("a", "о", "и", and and etc), then the $ diff->render($ renderer) returns an empty string. Can you adapt phpspec/php-diff to work with utf-8?
The text was updated successfully, but these errors were encountered: