Skip to content

Commit a412a29

Browse files
author
Jason Oster
committed
Another additional performance improvement: Call availableCalendars() only once
1 parent 2983cba commit a412a29

File tree

4 files changed

+12
-8
lines changed

4 files changed

+12
-8
lines changed

day.php

+3-2
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,14 @@
3636

3737

3838
// select for calendars
39-
$list_icals = display_ical_list(availableCalendars($username, $password, $phpiCal_config->ALL_CALENDARS_COMBINED));
39+
$available = availableCalendars($username, $password, $phpiCal_config->ALL_CALENDARS_COMBINED);
40+
$list_icals = display_ical_list($available);
4041
$list_years = list_years();
4142
$list_months = list_months();
4243
$list_weeks = list_weeks();
4344
$list_jumps = list_jumps();
4445
$list_calcolors = list_calcolors();
45-
$list_icals_pick = display_ical_list(availableCalendars($username, $password, $phpiCal_config->ALL_CALENDARS_COMBINED), TRUE);
46+
$list_icals_pick = display_ical_list($available, TRUE);
4647

4748
// login/logout
4849
$is_logged_in = ($username != '' && !$invalid_login) ? true : false;

month.php

+3-2
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,14 @@
4646
$num_of_events2 = 0;
4747

4848
// select for calendars
49-
$list_icals = display_ical_list(availableCalendars($username, $password, $phpiCal_config->ALL_CALENDARS_COMBINED));
49+
$available = availableCalendars($username, $password, $phpiCal_config->ALL_CALENDARS_COMBINED);
50+
$list_icals = display_ical_list($available);
5051
$list_years = list_years();
5152
$list_months = list_months();
5253
$list_weeks = list_weeks();
5354
$list_jumps = list_jumps();
5455
$list_calcolors = list_calcolors();
55-
$list_icals_pick = display_ical_list(availableCalendars($username, $password, $phpiCal_config->ALL_CALENDARS_COMBINED), TRUE);
56+
$list_icals_pick = display_ical_list($available, TRUE);
5657

5758
// login/logout
5859
$is_logged_in = ($username != '' && !$invalid_login) ? true : false;

week.php

+3-2
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,14 @@
3737
$this_year = $day_array2[1];
3838

3939
// select for calendars
40-
$list_icals = display_ical_list(availableCalendars($username, $password, $phpiCal_config->ALL_CALENDARS_COMBINED));
40+
$available = availableCalendars($username, $password, $phpiCal_config->ALL_CALENDARS_COMBINED);
41+
$list_icals = display_ical_list($available);
4142
$list_years = list_years();
4243
$list_months = list_months();
4344
$list_weeks = list_weeks();
4445
$list_jumps = list_jumps();
4546
$list_calcolors = list_calcolors();
46-
$list_icals_pick = display_ical_list(availableCalendars($username, $password, $phpiCal_config->ALL_CALENDARS_COMBINED), TRUE);
47+
$list_icals_pick = display_ical_list($available, TRUE);
4748

4849
// login/logout
4950
$is_logged_in = ($username != '' && !$invalid_login) ? true : false;

year.php

+3-2
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,16 @@
2323
$this_year = $day_array2[1];
2424

2525
// select for calendars
26-
$list_icals = display_ical_list(availableCalendars($username, $password, $phpiCal_config->ALL_CALENDARS_COMBINED));
26+
$available = availableCalendars($username, $password, $phpiCal_config->ALL_CALENDARS_COMBINED);
27+
$list_icals = display_ical_list($available);
2728
$list_years = list_years();
2829
$list_months = list_months();
2930
$list_weeks = list_weeks();
3031
$list_jumps = list_jumps();
3132
$list_calcolors = '<img src="templates/'.$template.'/images/allday_dot.gif" alt=" " width="11" height="10" border="0" />'.$lang['l_all_day'].'<br>
3233
<img src="templates/'.$template.'/images/event_dot.gif" alt=" " width="11" height="10" border="0" />'.$lang['l_event']."<br>";
3334
;
34-
$list_icals_pick = display_ical_list(availableCalendars($username, $password, $phpiCal_config->ALL_CALENDARS_COMBINED), TRUE);
35+
$list_icals_pick = display_ical_list($available, TRUE);
3536

3637
// login/logout
3738
$is_logged_in = ($username != '' && !$invalid_login) ? true : false;

0 commit comments

Comments
 (0)