bugfix: fixed a memory leak in ssl.cert_pem_to_der(), caught by valgrind.

agentzh · agentzh · commit b60f53f97bfe · 2016-05-02T12:43:52.000-07:00
diff --git a/src/ngx_http_lua_ssl_certby.c b/src/ngx_http_lua_ssl_certby.c
@@ -853,6 +853,7 @@ ngx_http_lua_ffi_cert_pem_to_der(const u_char *pem, size_t pem_len, u_char *der,
     x509 = PEM_read_bio_X509_AUX(bio, NULL, NULL, NULL);
     if (x509 == NULL) {
         *err = "PEM_read_bio_X509_AUX() failed";
+        BIO_free(bio);
         ERR_clear_error();
         return NGX_ERROR;
     }

Original file line number	Diff line number	Diff line change
`@@ -853,6 +853,7 @@ ngx_http_lua_ffi_cert_pem_to_der(const u_char pem, size_t pem_len, u_char der,`
`853`	`853`	`x509 = PEM_read_bio_X509_AUX(bio, NULL, NULL, NULL);`
`854`	`854`	`if (x509 == NULL) {`
`855`	`855`	`*err = "PEM_read_bio_X509_AUX() failed";`
	`856`	`+ BIO_free(bio);`
`856`	`857`	`ERR_clear_error();`
`857`	`858`	`return NGX_ERROR;`
`858`	`859`	`}`