You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Before this any unpack error will be raised after the unpack step. Now
this is postponed until we get manifest, and if then use included
folders from manifest to filter errors which are not for the files from
included folders.
I made a folder which has symlinks and file names with same names in
different casing.
```
sample
├── build.zig
├── build.zig.zon
├── dir1
│ └── dir2
│ └── dir3
│ ├── file1
│ ├── file2
│ └── file3
├── dir4
│ └── dir5
│ └── dir6
│ ├── file1 -> ../../../dir1/dir2/dir3/file1
│ └── file2_symlink -> ../../../dir1/dir2/dir3/file2
├── dir7
│ └── dir8
│ └── dir9
│ ├── file4
│ └── File4
└── src
├── main.zig
└── root.zig
```
Then pack this into sample.tar and another one sample_src.tar where
build.zig.zon has only src in paths (excluded all problematic folders):
```Zig
.paths = .{
"src",
},
```
On Linux both tars get unpacked. On Windows and macOS both fail before
this changes and second succeds after this change.
Windows (with disabled symlinks):
```
C:\Users\ianic\code\zig-bin\zig.exe build --global-cache-dir zig-global-cache-release
C:\Users\ianic\code\issues\fetch\build.zig.zon:78:20: error: unable to unpack tarball
.url = "http://10.211.55.26:8000/sample.tar",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
note: unable to create file 'dir7/dir8/dir9/file4': PathAlreadyExists
note: unable to create symlink from 'dir4/dir5/dir6/file1' to '../../../dir1/dir2/dir3/file1': AccessDenied
note: unable to create symlink from 'dir4/dir5/dir6/file2_symlink' to '../../../dir1/dir2/dir3/file2': AccessDenied
C:\Users\ianic\code\issues\fetch\build.zig.zon:85:20: error: unable to unpack tarball
.url = "http://10.211.55.26:8000/sample_src.tar",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
note: unable to create file 'dir7/dir8/dir9/file4': PathAlreadyExists
note: unable to create symlink from 'dir4/dir5/dir6/file1' to '../../../dir1/dir2/dir3/file1': AccessDenied
note: unable to create symlink from 'dir4/dir5/dir6/file2_symlink' to '../../../dir1/dir2/dir3/file2': AccessDenied
PS C:\Users\ianic\code\issues\fetch> C:\Users\ianic\code\zig-bin\bin\zig.exe build --global-cache-dir zig-global-cache-release
C:\Users\ianic\code\zig-io\build\stage3\bin\zig.exe build --global-cache-dir zig-global-cache-master
C:\Users\ianic\code\issues\fetch\build.zig.zon:78:20: error: unable to unpack
.url = "http://10.211.55.26:8000/sample.tar",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
note: unable to create file 'dir7/dir8/dir9/file4': PathAlreadyExists
note: unable to create symlink from 'dir4/dir5/dir6/file1' to '../../../dir1/dir2/dir3/file1': AccessDenied
note: unable to create symlink from 'dir4/dir5/dir6/file2_symlink' to '../../../dir1/dir2/dir3/file2': AccessDenied
```
macOS
```
Fetch Packages [45/40] /Users/ianic/code/zig/issues/fetch/build.zig.zon:75:20: error: unable to unpack tarball
.url = "file:///Users/ianic/code/zig/issues/fetch/sample.tar",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
note: unable to create file 'dir7/dir8/dir9/file4': PathAlreadyExists
/Users/ianic/code/zig/issues/fetch/build.zig.zon:80:20: error: unable to unpack tarball
.url = "file:///Users/ianic/code/zig/issues/fetch/sample_src.tar",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Fetch Packages [41/40] /Users/ianic/code/zig/issues/fetch/build.zig.zon:75:20: error: unable to unpack
.url = "file:///Users/ianic/code/zig/issues/fetch/sample.tar",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
note: unable to create file 'dir7/dir8/dir9/file4': PathAlreadyExists
```
0 commit comments