Skip to content

Commit 2b99182

Browse files
committed
stage2: cleanups to --compress-debug-sections
* make the setting in the linker backend be non-optional; by this time all defaults are supposed to be resolved. * integrate with `zig cc` * change the CLI parsing to match C compiler parsing, allowing `--compress-debug-sections` alone to choose a default encoding of zlib.
1 parent 1f410b5 commit 2b99182

File tree

6 files changed

+48
-27
lines changed

6 files changed

+48
-27
lines changed

src/Compilation.zig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1688,7 +1688,7 @@ pub fn create(gpa: Allocator, options: InitOptions) !*Compilation {
16881688
.no_builtin = options.no_builtin,
16891689
.allow_shlib_undefined = options.linker_allow_shlib_undefined,
16901690
.bind_global_refs_locally = options.linker_bind_global_refs_locally orelse false,
1691-
.compress_debug_sections = options.linker_compress_debug_sections,
1691+
.compress_debug_sections = options.linker_compress_debug_sections orelse .none,
16921692
.import_memory = options.linker_import_memory orelse false,
16931693
.import_table = options.linker_import_table,
16941694
.export_table = options.linker_export_table,
@@ -2461,7 +2461,7 @@ fn addNonIncrementalStuffToCacheManifest(comp: *Compilation, man: *Cache.Manifes
24612461
man.hash.add(comp.bin_file.options.z_now);
24622462
man.hash.add(comp.bin_file.options.z_relro);
24632463
man.hash.add(comp.bin_file.options.hash_style);
2464-
man.hash.addOptional(comp.bin_file.options.compress_debug_sections);
2464+
man.hash.add(comp.bin_file.options.compress_debug_sections);
24652465
man.hash.add(comp.bin_file.options.include_compiler_rt);
24662466
if (comp.bin_file.options.link_libc) {
24672467
man.hash.add(comp.bin_file.options.libc_installation != null);

src/clang_options_data.zig

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -2308,7 +2308,7 @@ flagpd1("compiler-options-dump"),
23082308
.{
23092309
.name = "compress-debug-sections",
23102310
.syntax = .flag,
2311-
.zig_equivalent = .other,
2311+
.zig_equivalent = .compress_debug_sections,
23122312
.pd1 = true,
23132313
.pd2 = true,
23142314
.psl = false,
@@ -3834,7 +3834,7 @@ m("mavx512cd"),
38343834
m("mavx512dq"),
38353835
m("mavx512er"),
38363836
m("mavx512f"),
3837-
flagpd1("mavx512fp16"),
3837+
m("mavx512fp16"),
38383838
m("mavx512ifma"),
38393839
m("mavx512pf"),
38403840
m("mavx512vbmi"),
@@ -3867,7 +3867,7 @@ flagpd1("mconstructor-aliases"),
38673867
flagpd1("mcpu=?"),
38683868
m("mcrbits"),
38693869
m("mcrc"),
3870-
flagpd1("mcrc32"),
3870+
m("mcrc32"),
38713871
m("mcumode"),
38723872
m("mcx16"),
38733873
sepd1("mdebug-pass"),
@@ -3892,8 +3892,8 @@ flagpd1("mfancy-math-387"),
38923892
flagpd1("mfentry"),
38933893
flagpd1("mfix4300"),
38943894
flagpd1("mfix-and-continue"),
3895-
flagpd1("mfix-cmse-cve-2021-35465"),
3896-
flagpd1("mfix-cortex-a53-835769"),
3895+
m("mfix-cmse-cve-2021-35465"),
3896+
m("mfix-cortex-a53-835769"),
38973897
m("mfloat128"),
38983898
sepd1("mfloat-abi"),
38993899
m("mfma"),
@@ -3913,8 +3913,8 @@ flagpd1("mglobal-merge"),
39133913
flagpd1("mgpopt"),
39143914
m("mhard-float"),
39153915
m("mhvx"),
3916-
flagpd1("mhvx-ieee-fp"),
3917-
flagpd1("mhvx-qfloat"),
3916+
m("mhvx-ieee-fp"),
3917+
m("mhvx-qfloat"),
39183918
m("mhreset"),
39193919
m("mhtm"),
39203920
flagpd1("miamcu"),
@@ -4005,7 +4005,7 @@ m("mno-avx512cd"),
40054005
m("mno-avx512dq"),
40064006
m("mno-avx512er"),
40074007
m("mno-avx512f"),
4008-
flagpd1("mno-avx512fp16"),
4008+
m("mno-avx512fp16"),
40094009
m("mno-avx512ifma"),
40104010
m("mno-avx512pf"),
40114011
m("mno-avx512vbmi"),
@@ -4019,7 +4019,7 @@ flagpd1("mno-backchain"),
40194019
m("mno-bmi"),
40204020
m("mno-bmi2"),
40214021
flagpd1("mno-branch-likely"),
4022-
flagpd1("mno-bti-at-return-twice"),
4022+
m("mno-bti-at-return-twice"),
40234023
m("mno-bulk-memory"),
40244024
flagpd1("mno-check-zero-division"),
40254025
m("mno-cldemote"),
@@ -4032,7 +4032,7 @@ flagpd1("mno-constant-cfstrings"),
40324032
flagpd1("mno-constructor-aliases"),
40334033
m("mno-crbits"),
40344034
m("mno-crc"),
4035-
flagpd1("mno-crc32"),
4035+
m("mno-crc32"),
40364036
m("mno-cumode"),
40374037
m("mno-cx16"),
40384038
m("mno-dsp"),
@@ -4044,8 +4044,8 @@ flagpd1("mnoexecstack"),
40444044
m("mno-execute-only"),
40454045
flagpd1("mno-extern-sdata"),
40464046
m("mno-f16c"),
4047-
flagpd1("mno-fix-cmse-cve-2021-35465"),
4048-
flagpd1("mno-fix-cortex-a53-835769"),
4047+
m("mno-fix-cmse-cve-2021-35465"),
4048+
m("mno-fix-cortex-a53-835769"),
40494049
m("mno-float128"),
40504050
m("mno-fma"),
40514051
m("mno-fma4"),
@@ -4058,8 +4058,8 @@ m("mno-ginv"),
40584058
flagpd1("mno-global-merge"),
40594059
flagpd1("mno-gpopt"),
40604060
m("mno-hvx"),
4061-
flagpd1("mno-hvx-ieee-fp"),
4062-
flagpd1("mno-hvx-qfloat"),
4061+
m("mno-hvx-ieee-fp"),
4062+
m("mno-hvx-qfloat"),
40634063
m("mno-hreset"),
40644064
m("mno-htm"),
40654065
flagpd1("mno-iamcu"),
@@ -4137,7 +4137,7 @@ m("mno-reference-types"),
41374137
m("mno-relax"),
41384138
flagpd1("mno-relax-all"),
41394139
flagpd1("mno-relax-pic-calls"),
4140-
flagpd1("mno-relaxed-simd"),
4140+
m("mno-relaxed-simd"),
41414141
flagpd1("mno-restrict-it"),
41424142
m("mno-retpoline"),
41434143
m("mno-retpoline-external-thunk"),
@@ -4259,7 +4259,7 @@ flagpd1("mrelax-pic-calls"),
42594259
.pd2 = true,
42604260
.psl = false,
42614261
},
4262-
flagpd1("mrelaxed-simd"),
4262+
m("mrelaxed-simd"),
42634263
sepd1("mrelocation-model"),
42644264
flagpd1("mrestrict-it"),
42654265
m("mretpoline"),
@@ -4323,7 +4323,7 @@ m("mv66"),
43234323
m("mv67"),
43244324
flagpd1("mv67t"),
43254325
m("mv68"),
4326-
flagpd1("mv69"),
4326+
m("mv69"),
43274327
m("mvaes"),
43284328
m("mvirt"),
43294329
m("mvpclmulqdq"),
@@ -5087,7 +5087,7 @@ joinpd1("msign-return-address-key="),
50875087
.{
50885088
.name = "compress-debug-sections=",
50895089
.syntax = .joined,
5090-
.zig_equivalent = .other,
5090+
.zig_equivalent = .compress_debug_sections,
50915091
.pd1 = true,
50925092
.pd2 = true,
50935093
.psl = false,

src/link.zig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ pub const Options = struct {
123123
nxcompat: bool,
124124
dynamicbase: bool,
125125
linker_optimization: u8,
126-
compress_debug_sections: ?CompressDebugSections,
126+
compress_debug_sections: CompressDebugSections,
127127
bind_global_refs_locally: bool,
128128
import_memory: bool,
129129
import_table: bool,

src/link/Elf.zig

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1351,7 +1351,7 @@ fn linkWithLLD(self: *Elf, comp: *Compilation, prog_node: *std.Progress.Node) !v
13511351
link.hashAddSystemLibs(&man.hash, self.base.options.system_libs);
13521352
man.hash.add(allow_shlib_undefined);
13531353
man.hash.add(self.base.options.bind_global_refs_locally);
1354-
man.hash.addOptional(self.base.options.compress_debug_sections);
1354+
man.hash.add(self.base.options.compress_debug_sections);
13551355
man.hash.add(self.base.options.tsan);
13561356
man.hash.addOptionalBytes(self.base.options.sysroot);
13571357
man.hash.add(self.base.options.linker_optimization);
@@ -1755,9 +1755,9 @@ fn linkWithLLD(self: *Elf, comp: *Compilation, prog_node: *std.Progress.Node) !v
17551755
try argv.append("--allow-shlib-undefined");
17561756
}
17571757

1758-
if (self.base.options.compress_debug_sections) |how| {
1759-
const arg = try std.fmt.allocPrint(arena, "--compress-debug-sections={s}", .{@tagName(how)});
1760-
try argv.append(arg);
1758+
switch (self.base.options.compress_debug_sections) {
1759+
.none => {},
1760+
.zlib => try argv.append("--compress-debug-sections=zlib"),
17611761
}
17621762

17631763
if (self.base.options.bind_global_refs_locally) {

src/main.zig

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -443,8 +443,9 @@ const usage_build_generic =
443443
\\ -dynamic Force output to be dynamically linked
444444
\\ -static Force output to be statically linked
445445
\\ -Bsymbolic Bind global references locally
446-
\\ --compress-debug-sections= Compress DWARF debug sections
447-
\\ none|zlib
446+
\\ --compress-debug-sections=[e] Debug section compression settings
447+
\\ none No compression
448+
\\ zlib Compression with deflate/inflate
448449
\\ --subsystem [subsystem] (Windows) /SUBSYSTEM:<subsystem> to the linker
449450
\\ --stack [size] Override default stack size
450451
\\ --image-base [addr] Set base address for executable image
@@ -946,6 +947,8 @@ fn buildOutputType(
946947
linker_compress_debug_sections = std.meta.stringToEnum(link.CompressDebugSections, param) orelse {
947948
fatal("expected --compress-debug-sections=[none|zlib], found '{s}'", .{param});
948949
};
950+
} else if (mem.eql(u8, arg, "--compress-debug-sections")) {
951+
linker_compress_debug_sections = link.CompressDebugSections.zlib;
949952
} else if (mem.eql(u8, arg, "-pagezero_size")) {
950953
const next_arg = args_iter.next() orelse {
951954
fatal("expected parameter after {s}", .{arg});
@@ -1648,6 +1651,15 @@ fn buildOutputType(
16481651
.weak_library => try system_libs.put(it.only_arg, .{ .weak = true }),
16491652
.weak_framework => try frameworks.put(gpa, it.only_arg, .{ .weak = true }),
16501653
.headerpad_max_install_names => headerpad_max_install_names = true,
1654+
.compress_debug_sections => {
1655+
if (it.only_arg.len == 0) {
1656+
linker_compress_debug_sections = .zlib;
1657+
} else {
1658+
linker_compress_debug_sections = std.meta.stringToEnum(link.CompressDebugSections, it.only_arg) orelse {
1659+
fatal("expected [none|zlib] after --compress-debug-sections, found '{s}'", .{it.only_arg});
1660+
};
1661+
}
1662+
},
16511663
}
16521664
}
16531665
// Parse linker args.
@@ -4617,6 +4629,7 @@ pub const ClangArgIterator = struct {
46174629
weak_library,
46184630
weak_framework,
46194631
headerpad_max_install_names,
4632+
compress_debug_sections,
46204633
};
46214634

46224635
const Args = struct {

tools/update_clang_options.zig

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -460,6 +460,14 @@ const known_options = [_]KnownOpt{
460460
.name = "headerpad_max_install_names",
461461
.ident = "headerpad_max_install_names",
462462
},
463+
.{
464+
.name = "compress-debug-sections",
465+
.ident = "compress_debug_sections",
466+
},
467+
.{
468+
.name = "compress-debug-sections=",
469+
.ident = "compress_debug_sections",
470+
},
463471
};
464472

465473
const blacklisted_options = [_][]const u8{};

0 commit comments

Comments
 (0)