thread: don't leak the thread in spawnManager (#21379)

Rexicon226 · web-flow · commit 421fbd939c45 · 2024-09-11T01:04:59.000Z
diff --git a/lib/std/Thread/WaitGroup.zig b/lib/std/Thread/WaitGroup.zig
@@ -63,5 +63,6 @@ pub fn spawnManager(
         }
     };
     wg.start();
-    _ = std.Thread.spawn(.{}, Manager.run, .{ wg, args }) catch Manager.run(wg, args);
+    const t = std.Thread.spawn(.{}, Manager.run, .{ wg, args }) catch return Manager.run(wg, args);
+    t.detach();
 }

Original file line number	Diff line number	Diff line change
`@@ -63,5 +63,6 @@ pub fn spawnManager(`
`63`	`63`	`}`
`64`	`64`	`};`
`65`	`65`	`wg.start();`
`66`		`- _ = std.Thread.spawn(.{}, Manager.run, .{ wg, args }) catch Manager.run(wg, args);`
	`66`	`+ const t = std.Thread.spawn(.{}, Manager.run, .{ wg, args }) catch return Manager.run(wg, args);`
	`67`	`+ t.detach();`
`67`	`68`	`}`