Package: Fix path separator not being escaped between root_dir and sub_path

squeek502 · andrewrk · commit 42998e637b29 · 2023-10-10T23:02:03.000-07:00
Fixes a package fetching regression on Windows. Closes #17477
diff --git a/src/Package.zig b/src/Package.zig
@@ -124,7 +124,7 @@ pub const Path = struct {
             };
             if (self.root_dir.path) |p| {
                 try stringEscape(p, f, options, writer);
-                if (self.sub_path.len > 0) try writer.writeAll(fs.path.sep_str);
+                if (self.sub_path.len > 0) try stringEscape(fs.path.sep_str, f, options, writer);
             }
             if (self.sub_path.len > 0) {
                 try stringEscape(self.sub_path, f, options, writer);

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ pub const Path = struct {`
`124`	`124`	`};`
`125`	`125`	`if (self.root_dir.path) \|p\| {`
`126`	`126`	`try stringEscape(p, f, options, writer);`
`127`		`- if (self.sub_path.len > 0) try writer.writeAll(fs.path.sep_str);`
	`127`	`+ if (self.sub_path.len > 0) try stringEscape(fs.path.sep_str, f, options, writer);`
`128`	`128`	`}`
`129`	`129`	`if (self.sub_path.len > 0) {`
`130`	`130`	`try stringEscape(self.sub_path, f, options, writer);`