std.tar: cleanups and fixes

tar.zig:
* convert V7Header, UstarHeader, StarHeader, GnuHeader to have fields of
  byte arrays instead of accessor methods.
* Header.getFormat() - optimize by using 64 bit compares rather than
  mem.eql().
* gnu_long{name,link} and pax headers - allow them to be longer than
  512 bytes by adding an allocator param to pipeToFileSystem().
* symlinks: cleanup logic and skip if wasi
* use std.os.toPosixPath() instead of custom one.
* on windows, use custom openDirW() which adds FILE_WRITE_ATTRIBUTES in
  attempt to fix ci errors.

src/Package.zig: pass gpa to pipeToFileSystem()

tests: minor cosmetic changes

Author: travisstaloch

lib/std/compress/tar.zig

@@ -1,4 +1,4 @@
-test "std.tar" {
+test {
     _ = @import("tar/reader_test.zig");
     _ = @import("tar/test_decompress.zig");
 }

lib/std/compress/tar/reader_test.zig

@@ -25,9 +25,9 @@ const TestCase = struct {
     skip: bool = false, // Wether to skip test case
 };
 
-test "tar validate testdata headers" {
-    // skip if wine and debug mode due to 'incorrect alignment'
-    // TODO re-enable after https://github.com/ziglang/zig/issues/14036 is solved
+test "std.tar validate testdata headers" {
+    // skip due to 'incorrect alignment', maybe the same as
+    // https://github.com/ziglang/zig/issues/14036
     if (builtin.os.tag == .windows and builtin.mode == .Debug)
         return error.SkipZigTest;
 
@@ -671,8 +671,9 @@ test "tar validate testdata headers" {
         var fbs = try test_common.decompressGz("testdata/" ++ test_case.file ++ ".gz", talloc);
         defer talloc.free(fbs.buffer);
         const reader = fbs.reader();
-        var buf: [tar.block_len * 4]u8 = undefined;
-        var iter = tar.headerIterator(reader, &buf);
+        var buf: [tar.block_len]u8 = undefined;
+        var iter = tar.headerIterator(reader, &buf, talloc);
+        defer iter.deinit();
         for (test_case.headers, 0..) |header_, i| {
             // since we don't maintain a hash map of pax records, merge pax_recs
             // into this header record

lib/std/compress/tar/test_decompress.zig

@@ -6,9 +6,9 @@ const talloc = testing.allocator;
 const builtin = @import("builtin");
 const test_common = @import("test_common.zig");
 
-test "tar decompress testdata" {
-    // skip if wine and debug mode due to 'incorrect alignment'
-    // TODO re-enable after https://github.com/ziglang/zig/issues/14036 is solved
+test "std.tar decompress testdata" {
+    // skip due to 'incorrect alignment', maybe the same as
+    // https://github.com/ziglang/zig/issues/14036
     if (builtin.os.tag == .windows and builtin.mode == .Debug)
         return error.SkipZigTest;
 
@@ -32,23 +32,17 @@ test "tar decompress testdata" {
         "gnu-multi-hdrs.tar",
     };
 
-    var cache_dir = testing.tmpDir(.{});
-    defer cache_dir.cleanup();
-
     inline for (test_files) |test_file| {
         var fbs = try test_common.decompressGz("testdata/" ++ test_file ++ ".gz", talloc);
         defer talloc.free(fbs.buffer);
-        {
-            var output_dir = try cache_dir.dir.makeOpenPath(test_file, .{});
-            defer output_dir.close();
-            try tar.pipeToFileSystem(output_dir, fbs.reader(), .{ .mode_mode = .ignore });
-        }
-        try cache_dir.dir.deleteTree(test_file);
+        try testDecompressTarToTmp(&fbs, .{ .mode_mode = .ignore });
         fbs.reset();
-        {
-            var output_dir = try cache_dir.dir.makeOpenPath(test_file, .{});
-            defer output_dir.close();
-            try tar.pipeToFileSystem(output_dir, fbs.reader(), .{ .mode_mode = .executable_bit_only });
-        }
+        try testDecompressTarToTmp(&fbs, .{ .mode_mode = .executable_bit_only });
     }
 }
+
+fn testDecompressTarToTmp(fbs: *std.io.FixedBufferStream([]u8), options: tar.Options) !void {
+    var tmpdir = testing.tmpDir(.{});
+    defer tmpdir.cleanup();
+    try tar.pipeToFileSystem(talloc, tmpdir.dir, fbs.reader(), options);
+}