more user-friendly error message for some clang diagnostics

andrewrk · andrewrk · commit 5e37fc0746a7 · 2020-02-16T01:45:48.000-05:00
See #4455
diff --git a/src/error.cpp b/src/error.cpp
@@ -64,7 +64,7 @@ const char *err_str(Error err) {
         case ErrorInvalidCpuFeatures: return "invalid CPU features";
         case ErrorInvalidLlvmCpuFeaturesFormat: return "invalid LLVM CPU features format";
         case ErrorUnknownApplicationBinaryInterface: return "unknown application binary interface";
-        case ErrorASTUnitFailure: return "ASTUnit failure";
+        case ErrorASTUnitFailure: return "compiler bug: clang encountered a compile error, but the libclang API does not expose the error. See https://github.com/ziglang/zig/issues/4455 for more details";
     }
     return "(invalid error)";
 }

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ const char *err_str(Error err) {`
`64`	`64`	`case ErrorInvalidCpuFeatures: return "invalid CPU features";`
`65`	`65`	`case ErrorInvalidLlvmCpuFeaturesFormat: return "invalid LLVM CPU features format";`
`66`	`66`	`case ErrorUnknownApplicationBinaryInterface: return "unknown application binary interface";`
`67`		`- case ErrorASTUnitFailure: return "ASTUnit failure";`
	`67`	`+ case ErrorASTUnitFailure: return "compiler bug: clang encountered a compile error, but the libclang API does not expose the error. See https://github.com/ziglang/zig/issues/4455 for more details";`
`68`	`68`	`}`
`69`	`69`	`return "(invalid error)";`
`70`	`70`	`}`