Skip to content

Commit 8796123

Browse files
committed
add behavior test for tail calls
closes #9703
1 parent 00d6a4d commit 8796123

File tree

2 files changed

+60
-0
lines changed

2 files changed

+60
-0
lines changed

test/behavior.zig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,7 @@ test {
149149
_ = @import("behavior/byval_arg_var.zig");
150150
_ = @import("behavior/c_char_signedness.zig");
151151
_ = @import("behavior/call.zig");
152+
_ = @import("behavior/call_tail.zig");
152153
_ = @import("behavior/cast.zig");
153154
_ = @import("behavior/cast_int.zig");
154155
_ = @import("behavior/comptime_memory.zig");

test/behavior/call_tail.zig

Lines changed: 59 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
1+
const builtin = @import("builtin");
2+
const std = @import("std");
3+
const expect = std.testing.expect;
4+
5+
var base: usize = undefined;
6+
var result_off: [7]usize = undefined;
7+
var result_len: [7]usize = undefined;
8+
var result_index: usize = 0;
9+
10+
noinline fn insertionSort(data: []u64) void {
11+
result_off[result_index] = @intFromPtr(data.ptr) - base;
12+
result_len[result_index] = data.len;
13+
result_index += 1;
14+
if (data.len > 1) {
15+
var least_i: usize = 0;
16+
var i: usize = 1;
17+
while (i < data.len) : (i += 1) {
18+
if (data[i] < data[least_i])
19+
least_i = i;
20+
}
21+
std.mem.swap(u64, &data[0], &data[least_i]);
22+
23+
// there used to be a bug where
24+
// `data[1..]` is created on the stack
25+
// and pointed to by the first argument register
26+
// then stack is invalidated by the tailcall and
27+
// overwritten by callee
28+
// https://github.com/ziglang/zig/issues/9703
29+
return @call(.always_tail, insertionSort, .{data[1..]});
30+
}
31+
}
32+
33+
test "arguments pointed to on stack into tailcall" {
34+
switch (builtin.cpu.arch) {
35+
.wasm32, .mips, .mipsel, .powerpc, .powerpcle, .powerpc64le => return error.SkipZigTest,
36+
else => {},
37+
}
38+
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
39+
if (builtin.zig_backend == .stage2_c) return error.SkipZigTest;
40+
41+
var data = [_]u64{ 1, 6, 2, 7, 1, 9, 3 };
42+
base = @intFromPtr(&data);
43+
insertionSort(data[0..]);
44+
try expect(result_len[0] == 7);
45+
try expect(result_len[1] == 6);
46+
try expect(result_len[2] == 5);
47+
try expect(result_len[3] == 4);
48+
try expect(result_len[4] == 3);
49+
try expect(result_len[5] == 2);
50+
try expect(result_len[6] == 1);
51+
52+
try expect(result_off[0] == 0);
53+
try expect(result_off[1] == 8);
54+
try expect(result_off[2] == 16);
55+
try expect(result_off[3] == 24);
56+
try expect(result_off[4] == 32);
57+
try expect(result_off[5] == 40);
58+
try expect(result_off[6] == 48);
59+
}

0 commit comments

Comments
 (0)