Skip to content

Commit a2c6ecd

Browse files
andrewrkandrewrk
authored
Merge pull request #14918 from jacobly0/x86_64
x86_64: fix various backend crashes
2 parents 4414f9c + d70955b commit a2c6ecd

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

62 files changed

+135
-245
lines changed

‎src/arch/x86_64/CodeGen.zig

Lines changed: 134 additions & 102 deletions
Large diffs are not rendered by default.

‎test/behavior/align.zig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -568,7 +568,6 @@ fn overaligned_fn() align(0x1000) i32 {
568568
}
569569

570570
test "comptime alloc alignment" {
571-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
572571
if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
573572
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
574573
if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest; // TODO

‎test/behavior/array.zig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -591,7 +591,6 @@ test "type coercion of anon struct literal to array" {
591591
test "type coercion of pointer to anon struct literal to pointer to array" {
592592
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
593593
if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
594-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
595594
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
596595

597596
const S = struct {

‎test/behavior/bit_shifting.zig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ fn ShardedTable(comptime Key: type, comptime mask_bit_count: comptime_int, compt
6363
test "sharded table" {
6464
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
6565
if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
66-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
6766
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
6867

6968
// realistic 16-way sharding

‎test/behavior/bitreverse.zig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,6 @@ fn vector0() !void {
150150

151151
test "bitReverse vectors u0" {
152152
if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest;
153-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
154153

155154
comptime try vector0();
156155
try vector0();

‎test/behavior/bugs/1076.zig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ const mem = std.mem;
44
const expect = std.testing.expect;
55

66
test "comptime code should not modify constant data" {
7-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
87
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
98
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
109

‎test/behavior/bugs/11046.zig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ fn bar() !void {
1010
}
1111

1212
test "fixed" {
13-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
1413
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
1514
if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
1615
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO

‎test/behavior/bugs/11787.zig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ const testing = std.testing;
44

55
test "slicing zero length array field of struct" {
66
if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest; // TODO
7-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
87
if (builtin.zig_backend == .stage2_x86) return error.SkipZigTest; // TODO
98
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
109
if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO

‎test/behavior/bugs/12000.zig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ const T = struct {
77

88
test {
99
if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest; // TODO
10-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
1110
if (builtin.zig_backend == .stage2_x86) return error.SkipZigTest; // TODO
1211
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
1312
if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO

‎test/behavior/bugs/12119.zig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ const u32x8 = @Vector(8, u32);
66

77
test {
88
if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest; // TODO
9-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
109
if (builtin.zig_backend == .stage2_x86) return error.SkipZigTest; // TODO
1110
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
1211
if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO

‎test/behavior/bugs/12169.zig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ const builtin = @import("builtin");
33

44
test {
55
if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest; // TODO
6-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
76
if (builtin.zig_backend == .stage2_x86) return error.SkipZigTest; // TODO
87
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
98
if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO

‎test/behavior/bugs/12890.zig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ fn a(b: []u3, c: u3) void {
1010
}
1111
test {
1212
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
13-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
1413
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
1514

1615
var arr: [8]u3 = undefined;

‎test/behavior/bugs/13113.zig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ const Foo = extern struct {
88

99
test {
1010
if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest; // TODO
11-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
1211
if (builtin.zig_backend == .stage2_x86) return error.SkipZigTest; // TODO
1312
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
1413
if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO

‎test/behavior/bugs/1421.zig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ const S = struct {
99
};
1010

1111
test "functions with return type required to be comptime are generic" {
12-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
1312
const ti = S.method();
1413
try expect(@as(std.builtin.TypeId, ti) == std.builtin.TypeId.Struct);
1514
}

‎test/behavior/bugs/1607.zig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ fn checkAddress(s: []const u8) !void {
1313
test "slices pointing at the same address as global array." {
1414
if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
1515
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
16-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
1716
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
1817
try checkAddress(&a);
1918
comptime try checkAddress(&a);

‎test/behavior/bugs/2622.zig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ var buf: []u8 = undefined;
44

55
test "reslice of undefined global var slice" {
66
if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest; // TODO
7-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
87
if (builtin.zig_backend == .stage2_x86) return error.SkipZigTest; // TODO
98
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
109
if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO

‎test/behavior/bugs/2727.zig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ fn t() bool {
66

77
test {
88
if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest; // TODO
9-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
109
if (builtin.zig_backend == .stage2_x86) return error.SkipZigTest; // TODO
1110
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
1211
if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO

‎test/behavior/bugs/3742.zig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ pub const ArgSerializer = struct {
3737
test "fixed" {
3838
if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
3939
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
40-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
4140
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
4241
if (builtin.zig_backend == .stage2_llvm and
4342
builtin.cpu.arch == .aarch64 and builtin.os.tag == .windows) return error.SkipZigTest;

‎test/behavior/bugs/394.zig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ const expect = @import("std").testing.expect;
1111
const builtin = @import("builtin");
1212

1313
test "fixed" {
14-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
1514
const x = S{
1615
.x = 3,
1716
.y = E{ .B = 1 },

‎test/behavior/bugs/421.zig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ const builtin = @import("builtin");
22
const expect = @import("std").testing.expect;
33

44
test "bitCast to array" {
5-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
65
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
76
if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
87
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO

‎test/behavior/bugs/5398.zig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ var renderable: Renderable = undefined;
2121
test "assignment of field with padding" {
2222
if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
2323
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
24-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
2524
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
2625

2726
renderable = Renderable{

‎test/behavior/bugs/5487.zig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ pub fn writer() io.Writer(void, @typeInfo(@typeInfo(@TypeOf(write)).Fn.return_ty
1212
test "crash" {
1313
if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
1414
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
15-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
1615
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
1716
_ = io.multiWriter(.{writer()});
1817
}

‎test/behavior/bugs/656.zig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ const Value = struct {
1313
test "optional if after an if in a switch prong of a switch with 2 prongs in an else" {
1414
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
1515
if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
16-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
1716
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
1817
try foo(false, true);
1918
}

‎test/behavior/bugs/6947.zig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ fn destroy(ptr: *void) void {
66

77
test {
88
if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest; // TODO
9-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
109
if (builtin.zig_backend == .stage2_x86) return error.SkipZigTest; // TODO
1110
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
1211
if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO

‎test/behavior/byteswap.zig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,6 @@ fn vector0() !void {
116116

117117
test "@byteSwap vectors u0" {
118118
if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest;
119-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
120119

121120
comptime try vector0();
122121
try vector0();

‎test/behavior/byval_arg_var.zig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ const builtin = @import("builtin");
44
var result: []const u8 = "wrong";
55

66
test "pass string literal byvalue to a generic var param" {
7-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
87
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
98

109
start();

‎test/behavior/call.zig

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ test "super basic invocations" {
2121
test "basic invocations" {
2222
if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest; // TODO
2323
if (builtin.zig_backend == .stage2_c) return error.SkipZigTest; // TODO
24-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
2524
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
2625
if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
2726
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
@@ -56,7 +55,6 @@ test "basic invocations" {
5655
test "tuple parameters" {
5756
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
5857
if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
59-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
6058
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
6159

6260
const add = struct {

‎test/behavior/cast.zig

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,6 @@ fn expectFloatToInt(comptime F: type, f: F, comptime I: type, i: I) !void {
176176

177177
test "implicitly cast indirect pointer to maybe-indirect pointer" {
178178
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
179-
if (builtin.zig_backend == .stage2_x86_64 or builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
180179
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
181180

182181
const S = struct {
@@ -318,7 +317,6 @@ test "peer result null and comptime_int" {
318317

319318
test "*const ?[*]const T to [*c]const [*c]const T" {
320319
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
321-
if (builtin.zig_backend == .stage2_x86_64 or builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
322320
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
323321

324322
var array = [_]u8{ 'o', 'k' };
@@ -588,7 +586,6 @@ fn testCastPtrOfArrayToSliceAndPtr() !void {
588586

589587
test "cast *[1][*]const u8 to [*]const ?[*]const u8" {
590588
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
591-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
592589
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
593590

594591
const window_name = [1][*]const u8{"window name"};
@@ -927,7 +924,6 @@ test "peer cast *[N:x]T to *[N]T" {
927924

928925
test "peer cast [*:x]T to [*]T" {
929926
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
930-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
931927
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
932928

933929
const S = struct {
@@ -948,7 +944,6 @@ test "peer cast [*:x]T to [*]T" {
948944
test "peer cast [:x]T to [*:x]T" {
949945
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
950946
if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
951-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
952947
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
953948

954949
const S = struct {
@@ -989,7 +984,6 @@ test "peer type resolution implicit cast to return type" {
989984

990985
test "peer type resolution implicit cast to variable type" {
991986
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
992-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
993987
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
994988

995989
const S = struct {
@@ -1112,8 +1106,6 @@ fn incrementVoidPtrArray(array: ?*anyopaque, len: usize) void {
11121106
}
11131107

11141108
test "compile time int to ptr of function" {
1115-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
1116-
11171109
try foobar(FUNCTION_CONSTANT);
11181110
}
11191111

@@ -1505,7 +1497,6 @@ test "implicit cast from [:0]T to [*c]T" {
15051497
test "bitcast packed struct with u0" {
15061498
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
15071499
if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest; // TODO
1508-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
15091500

15101501
const S = packed struct(u2) { a: u0, b: u2 };
15111502
const s = @bitCast(S, @as(u2, 2));

‎test/behavior/defer.zig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ fn testNestedFnErrDefer() anyerror!void {
5050
}
5151

5252
test "return variable while defer expression in scope to modify it" {
53-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
5453
if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
5554
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
5655
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO

‎test/behavior/enum.zig

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -937,7 +937,6 @@ test "enum literal casting to error union with payload enum" {
937937
}
938938

939939
test "constant enum initialization with differing sizes" {
940-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
941940
if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
942941
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
943942
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
@@ -1137,7 +1136,6 @@ test "tag name functions are unique" {
11371136
}
11381137

11391138
test "size of enum with only one tag which has explicit integer tag type" {
1140-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
11411139
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
11421140
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
11431141

‎test/behavior/error.zig

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -144,15 +144,11 @@ test "implicit cast to optional to error union to return result loc" {
144144
}
145145

146146
test "fn returning empty error set can be passed as fn returning any error" {
147-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
148-
149147
entry();
150148
comptime entry();
151149
}
152150

153151
test "fn returning empty error set can be passed as fn returning any error - pointer" {
154-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
155-
156152
entryPtr();
157153
comptime entryPtr();
158154
}
@@ -219,7 +215,6 @@ fn testErrorSetType() !void {
219215
}
220216

221217
test "explicit error set cast" {
222-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
223218
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
224219

225220
try testExplicitErrorSetCast(Set1.A);
@@ -238,7 +233,6 @@ fn testExplicitErrorSetCast(set1: Set1) !void {
238233
}
239234

240235
test "comptime test error for empty error set" {
241-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
242236
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
243237

244238
try testComptimeTestErrorEmptySet(1234);
@@ -255,8 +249,6 @@ fn testComptimeTestErrorEmptySet(x: EmptyErrorSet!i32) !void {
255249
}
256250

257251
test "comptime err to int of error set with only 1 possible value" {
258-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
259-
260252
testErrToIntWithOnePossibleValue(error.A, @errorToInt(error.A));
261253
comptime testErrToIntWithOnePossibleValue(error.A, @errorToInt(error.A));
262254
}
@@ -426,7 +418,6 @@ test "nested error union function call in optional unwrap" {
426418
}
427419

428420
test "return function call to error set from error union function" {
429-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
430421
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
431422
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
432423

@@ -486,7 +477,6 @@ test "nested catch" {
486477
}
487478

488479
test "function pointer with return type that is error union with payload which is pointer of parent struct" {
489-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
490480
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
491481

492482
const S = struct {

‎test/behavior/eval.zig

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,6 @@ test "pointer to type" {
138138
}
139139

140140
test "a type constructed in a global expression" {
141-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
142141
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
143142
if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO
144143

@@ -1515,7 +1514,6 @@ test "x or true is comptime-known true" {
15151514
}
15161515

15171516
test "non-optional and optional array elements concatenated" {
1518-
if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest; // TODO
15191517
if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO
15201518
if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO
15211519
if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest; // TODO

0 commit comments

Comments
 (0)