stage2: fix double-free when error reading cached ZIR

andrewrk · andrewrk · commit ca974de5217d · 2021-12-06T14:29:49.000-07:00
We already had a `keep_zir` flag. No need to call deinit manually.
diff --git a/src/Module.zig b/src/Module.zig
@@ -2622,7 +2622,6 @@ pub fn astGenFile(mod: *Module, file: *File) !void {
                 zir.extra.len * 4;
             if (amt_read != amt_expected) {
                 log.warn("unexpected EOF reading cached ZIR for {s}", .{file.sub_file_path});
-                zir.deinit(gpa);
                 break :cached;
             }
             if (data_has_safety_tag) {

Original file line number	Diff line number	Diff line change
`@@ -2622,7 +2622,6 @@ pub fn astGenFile(mod: Module, file: File) !void {`
`2622`	`2622`	`zir.extra.len * 4;`
`2623`	`2623`	`if (amt_read != amt_expected) {`
`2624`	`2624`	`log.warn("unexpected EOF reading cached ZIR for {s}", .{file.sub_file_path});`
`2625`		`- zir.deinit(gpa);`
`2626`	`2625`	`break :cached;`
`2627`	`2626`	`}`
`2628`	`2627`	`if (data_has_safety_tag) {`