Skip to content

make zig fmt additionally format .zon files #14530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #14523
andrewrk opened this issue Feb 3, 2023 · 0 comments · Fixed by #14582
Closed
Tracked by #14523

make zig fmt additionally format .zon files #14530

andrewrk opened this issue Feb 3, 2023 · 0 comments · Fixed by #14582
Labels
breaking Implementing this issue could cause existing code to no longer compile or have different behavior. contributor friendly This issue is limited in scope and/or knowledge of Zig internals. enhancement Solving this issue will likely involve adding new logic or components to the codebase. zig fmt
Milestone
0.11.0

Comments

@andrewrk
Copy link
Member

andrewrk commented Feb 3, 2023

Extracted from #14523.

zig fmt recursively walks directories in search of files with the ".zig" extension and formats them. It should additionally do this for ".zon" files. This is technically a breaking change since it is theoretically possible that this extension is being used for something else.

The logic for this is primarily in src/main.zig.
@andrewrk andrewrk added enhancement Solving this issue will likely involve adding new logic or components to the codebase. contributor friendly This issue is limited in scope and/or knowledge of Zig internals. breaking Implementing this issue could cause existing code to no longer compile or have different behavior. zig fmt labels Feb 3, 2023
@andrewrk andrewrk added this to the 0.11.0 milestone Feb 3, 2023
@andrewrk andrewrk mentioned this issue Feb 3, 2023
Merged
5 tasks
@alichraghi alichraghi mentioned this issue Feb 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Implementing this issue could cause existing code to no longer compile or have different behavior. contributor friendly This issue is limited in scope and/or knowledge of Zig internals. enhancement Solving this issue will likely involve adding new logic or components to the codebase. zig fmt
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

zig fmt: additionally format .zon files alichraghi/zig
1 participant
@andrewrk