Skip to content

header files were erroneously dropped in past commit #23233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ah-quant opened this issue Mar 13, 2025 · 2 comments
Closed

header files were erroneously dropped in past commit #23233

ah-quant opened this issue Mar 13, 2025 · 2 comments
Labels
bug Observed behavior contradicts documented or intended behavior

Comments

@ah-quant
Copy link

Zig Version

0.14.0

Steps to Reproduce and Observed Behavior

The commit 87083e8 dropped a lot of header files - essentially all that have multiple segments (A.B.h instead of A.h).

I want to use Zig in Bazel for C/C++ on Windows so I can get protobuf to build. Using https://github.com/uber/hermetic_cc_toolchain, I ran into it because the abseil dependency does not build without that file.
Found it using git log --all -1 -- .\lib\libc\include\any-windows-any\windows.globalization.h - and I saw that a lot more files were dropped.

Feel free to dismiss this if I'm mistaken. It just looks unintended to me. And thank you so much for your work on this amazingly valuable tool.

Expected Behavior

I'd expect the build to work and zig to be able to find that file.

@ah-quant ah-quant added the bug Observed behavior contradicts documented or intended behavior label Mar 13, 2025
@alexrp
Copy link
Member

alexrp commented Mar 13, 2025

This was done intentionally due to installation size concerns. See #23115 which has links to the relevant discussion, and ideas for what to do about this.

@alexrp alexrp closed this as completed Mar 13, 2025
@ah-quant
Copy link
Author

Thanks for your time and sorry for the noise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Observed behavior contradicts documented or intended behavior
Projects
None yet
Development

No branches or pull requests

2 participants