Skip to content

diagnose and fix bug in mach-o LLD code: invalid x86_64 Reference Kind #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andrewrk opened this issue Dec 19, 2017 · 4 comments
Closed

diagnose and fix bug in mach-o LLD code: invalid x86_64 Reference Kind #662

andrewrk opened this issue Dec 19, 2017 · 4 comments
Labels
contributor friendly This issue is limited in scope and/or knowledge of Zig internals. upstream An issue with a third party project that Zig uses.
Milestone
0.6.0

Comments

@andrewrk
Copy link
Member

Right now we have this patch applied to our in-tree fork of LLD:

ddca67a

It's an ugly workaround and does not solve the root cause. It's currently the only patch we have on top of LLD. If we fix this then we can go back to using upstream LLD.

Upstream bug: https://bugs.llvm.org/show_bug.cgi?id=32254

The bug is triggered by trivial hello world code. It seems the Mach-O LLD code is not well supported by the LLD team. Zig project will have to pick up the slack.
@andrewrk andrewrk added contributor friendly This issue is limited in scope and/or knowledge of Zig internals. upstream An issue with a third party project that Zig uses. labels Dec 19, 2017
@andrewrk andrewrk added this to the 0.3.0 milestone Dec 19, 2017
@andrewrk andrewrk modified the milestones: 0.3.0, 0.4.0 Feb 28, 2018
@andrewrk andrewrk modified the milestones: 0.4.0, 0.5.0 Feb 1, 2019
@andrewrk
Copy link
Member Author

andrewrk commented Apr 8, 2019

Related: #1535

@LemonBoy
Copy link
Contributor

I've sent a patch upstream.

@andrewrk andrewrk modified the milestones: 0.5.0, 0.6.0 Aug 27, 2019
@andrewrk
Copy link
Member Author

I made some squeaky wheel noises on the mailing list.

@andrewrk
Copy link
Member Author

This has been fixed in trunk. We can finally drop the last LLD patch when LLVM 10 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributor friendly This issue is limited in scope and/or knowledge of Zig internals. upstream An issue with a third party project that Zig uses.
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
2 participants
@LemonBoy @andrewrk