Skip to content

Comments are black on black by default! #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
d9k opened this issue Jul 19, 2024 · 2 comments
Open

Comments are black on black by default! #956

d9k opened this issue Jul 19, 2024 · 2 comments

Comments

@d9k
Copy link

d9k commented Jul 19, 2024

highlighters/main/main-highlighter.zsh:

${ZSH_HIGHLIGHT_STYLES[comment]:=fg=black,bold

Comments are black on black by default what is unreadable! Had to fix it with

ZSH_HIGHLIGHT_STYLES[comment]='fg=magenta,dimmed'

@d9k
Copy link
Author

d9k commented Jul 19, 2024

I use xfce4-terminal, having "bright black" color on my palette

Selection_2024-07-19_12-42-36_01

but setting Show bold text in bright colors is not enabled, there must be some another modifier than bold to make color bright

@sigboe
Copy link

sigboe commented Mar 31, 2025

I got it to be set to bright black using
ZSH_HIGHLIGHT_STYLES[comment]="fg=8"

It seams as "fg=black,bold" does not show the color black bright, but instead shows the color black.

and zsh-syntax-highlighting does not accept the word bright, I am not sure, but I believe this may be related to I think zsh doesn't normally use the word bright in its color scheme, and I think zsh-syntax-highlighting uses the official color format names. Please correct me if I am wrong here. Having access to these bright colors sounds a bit important for syntax highlighting, so I guess I wish that zsh-syntax-highlighting would make its own translation to translate the keyword bright to the colors 8 through 15, but that might be a lot of work, so we can always use the numbers of the colors.

The show bold text in bright colors might work as a workaround, using bold for bright colors is not very good. It means that no software can use bold fonts, since bold now has no well defined meaning. Also different terminal emulators might act differently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants