test [nfc]: Make addUserTopic async

This is the next step toward making handleEvent async.

Author: gnprice

test/model/message_list_test.dart

@@ -561,9 +561,9 @@ void main() async {
       await prepare(narrow: const AllMessagesNarrow());
       await store.addStreams([stream1, stream2]);
       await store.addSubscription(eg.subscription(stream1));
-      store.addUserTopic(stream1, 'B', UserTopicVisibilityPolicy.muted);
+      await store.addUserTopic(stream1, 'B', UserTopicVisibilityPolicy.muted);
       await store.addSubscription(eg.subscription(stream2, isMuted: true));
-      store.addUserTopic(stream2, 'C', UserTopicVisibilityPolicy.unmuted);
+      await store.addUserTopic(stream2, 'C', UserTopicVisibilityPolicy.unmuted);
 
       // Check filtering on fetchInitial…
       await prepareMessages(foundOldest: false, messages: [
@@ -618,8 +618,8 @@ void main() async {
       await prepare(narrow: StreamNarrow(stream.streamId));
       await store.addStream(stream);
       await store.addSubscription(eg.subscription(stream, isMuted: true));
-      store.addUserTopic(stream, 'A', UserTopicVisibilityPolicy.unmuted);
-      store.addUserTopic(stream, 'C', UserTopicVisibilityPolicy.muted);
+      await store.addUserTopic(stream, 'A', UserTopicVisibilityPolicy.unmuted);
+      await store.addUserTopic(stream, 'C', UserTopicVisibilityPolicy.muted);
 
       // Check filtering on fetchInitial…
       await prepareMessages(foundOldest: false, messages: [
@@ -662,7 +662,7 @@ void main() async {
       await prepare(narrow: TopicNarrow(stream.streamId, 'A'));
       await store.addStream(stream);
       await store.addSubscription(eg.subscription(stream, isMuted: true));
-      store.addUserTopic(stream, 'A', UserTopicVisibilityPolicy.muted);
+      await store.addUserTopic(stream, 'A', UserTopicVisibilityPolicy.muted);
 
       // Check filtering on fetchInitial…
       await prepareMessages(foundOldest: false, messages: [

test/model/stream_test.dart

@@ -116,21 +116,21 @@ void main() {
           .equals(UserTopicVisibilityPolicy.none);
       });
 
-      test('with nothing for topic', () {
-        final store = eg.store()
-          ..addUserTopic(stream1, 'other topic', UserTopicVisibilityPolicy.muted);
+      test('with nothing for topic', () async {
+        final store = eg.store();
+        await store.addUserTopic(stream1, 'other topic', UserTopicVisibilityPolicy.muted);
         check(store.topicVisibilityPolicy(stream1.streamId, 'topic'))
           .equals(UserTopicVisibilityPolicy.none);
       });
 
-      test('with topic present', () {
+      test('with topic present', () async {
         final store = eg.store();
         for (final policy in [
           UserTopicVisibilityPolicy.muted,
           UserTopicVisibilityPolicy.unmuted,
           UserTopicVisibilityPolicy.followed,
         ]) {
-          store.addUserTopic(stream1, 'topic', policy);
+          await store.addUserTopic(stream1, 'topic', policy);
           check(store.topicVisibilityPolicy(stream1.streamId, 'topic'))
             .equals(policy);
         }
@@ -165,7 +165,7 @@ void main() {
         final store = eg.store();
         await store.addStream(stream1);
         await store.addSubscription(eg.subscription(stream1));
-        store.addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.muted);
+        await store.addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.muted);
         check(store.isTopicVisibleInStream(stream1.streamId, 'topic')).isFalse();
         check(store.isTopicVisible        (stream1.streamId, 'topic')).isFalse();
       });
@@ -174,7 +174,7 @@ void main() {
         final store = eg.store();
         await store.addStream(stream1);
         await store.addSubscription(eg.subscription(stream1, isMuted: true));
-        store.addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.unmuted);
+        await store.addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.unmuted);
         check(store.isTopicVisibleInStream(stream1.streamId, 'topic')).isTrue();
         check(store.isTopicVisible        (stream1.streamId, 'topic')).isTrue();
       });
@@ -183,7 +183,7 @@ void main() {
         final store = eg.store();
         await store.addStream(stream1);
         await store.addSubscription(eg.subscription(stream1, isMuted: true));
-        store.addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.followed);
+        await store.addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.followed);
         check(store.isTopicVisibleInStream(stream1.streamId, 'topic')).isTrue();
         check(store.isTopicVisible        (stream1.streamId, 'topic')).isTrue();
       });
@@ -229,55 +229,55 @@ void main() {
     });
 
     group('events', () {
-      test('add with new stream', () {
-        final store = eg.store()
-          ..addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.muted);
+      test('add with new stream', () async {
+        final store = eg.store();
+        await store.addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.muted);
         compareTopicVisibility(store, [
           makeUserTopicItem(stream1, 'topic', UserTopicVisibilityPolicy.muted),
         ]);
       });
 
-      test('add in existing stream', () {
-        final store = eg.store()
-          ..addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.muted)
-          ..addUserTopic(stream1, 'other topic', UserTopicVisibilityPolicy.unmuted);
+      test('add in existing stream', () async {
+        final store = eg.store();
+        await store.addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.muted);
+        await store.addUserTopic(stream1, 'other topic', UserTopicVisibilityPolicy.unmuted);
         compareTopicVisibility(store, [
           makeUserTopicItem(stream1, 'topic', UserTopicVisibilityPolicy.muted),
           makeUserTopicItem(stream1, 'other topic', UserTopicVisibilityPolicy.unmuted),
         ]);
       });
 
-      test('update existing policy', () {
-        final store = eg.store()
-          ..addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.muted)
-          ..addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.unmuted);
+      test('update existing policy', () async {
+        final store = eg.store();
+        await store.addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.muted);
+        await store.addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.unmuted);
         compareTopicVisibility(store, [
           makeUserTopicItem(stream1, 'topic', UserTopicVisibilityPolicy.unmuted),
         ]);
       });
 
-      test('remove, with others in stream', () {
-        final store = eg.store()
-          ..addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.muted)
-          ..addUserTopic(stream1, 'other topic', UserTopicVisibilityPolicy.unmuted)
-          ..addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.none);
+      test('remove, with others in stream', () async {
+        final store = eg.store();
+        await store.addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.muted);
+        await store.addUserTopic(stream1, 'other topic', UserTopicVisibilityPolicy.unmuted);
+        await store.addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.none);
         compareTopicVisibility(store, [
           makeUserTopicItem(stream1, 'other topic', UserTopicVisibilityPolicy.unmuted),
         ]);
       });
 
-      test('remove, as last in stream', () {
-        final store = eg.store()
-          ..addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.muted)
-          ..addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.none);
+      test('remove, as last in stream', () async {
+        final store = eg.store();
+        await store.addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.muted);
+        await store.addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.none);
         compareTopicVisibility(store, [
         ]);
       });
 
-      test('treat unknown enum value as removing', () {
-        final store = eg.store()
-          ..addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.muted)
-          ..addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.unknown);
+      test('treat unknown enum value as removing', () async {
+        final store = eg.store();
+        await store.addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.muted);
+        await store.addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.unknown);
         compareTopicVisibility(store, [
         ]);
       });

test/model/test_store.dart

@@ -140,7 +140,7 @@ extension PerAccountStoreTestExtension on PerAccountStore {
     handleEvent(SubscriptionAddEvent(id: 1, subscriptions: subscriptions));
   }
 
-  void addUserTopic(ZulipStream stream, String topic, UserTopicVisibilityPolicy visibilityPolicy) {
+  Future<void> addUserTopic(ZulipStream stream, String topic, UserTopicVisibilityPolicy visibilityPolicy) async {
     handleEvent(UserTopicEvent(
       id: 1,
       streamId: stream.streamId,

test/model/unreads_test.dart

@@ -161,7 +161,7 @@ void main() {
       await streamStore.addSubscription(eg.subscription(stream1));
       await streamStore.addSubscription(eg.subscription(stream2));
       await streamStore.addSubscription(eg.subscription(stream3, isMuted: true));
-      streamStore.addUserTopic(stream1, 'a', UserTopicVisibilityPolicy.muted);
+      await streamStore.addUserTopic(stream1, 'a', UserTopicVisibilityPolicy.muted);
       fillWithMessages([
         eg.streamMessage(stream: stream1, topic: 'a', flags: []),
         eg.streamMessage(stream: stream1, topic: 'b', flags: []),
@@ -179,8 +179,8 @@ void main() {
       prepare();
       await streamStore.addStream(stream);
       await streamStore.addSubscription(eg.subscription(stream));
-      streamStore.addUserTopic(stream, 'a', UserTopicVisibilityPolicy.unmuted);
-      streamStore.addUserTopic(stream, 'c', UserTopicVisibilityPolicy.muted);
+      await streamStore.addUserTopic(stream, 'a', UserTopicVisibilityPolicy.unmuted);
+      await streamStore.addUserTopic(stream, 'c', UserTopicVisibilityPolicy.muted);
       fillWithMessages([
         eg.streamMessage(stream: stream, topic: 'a', flags: []),
         eg.streamMessage(stream: stream, topic: 'a', flags: []),

test/widgets/inbox_test.dart

@@ -199,7 +199,7 @@ void main() {
           streams: [stream],
           subscriptions: [subscription],
           unreadMessages: [eg.streamMessage(stream: stream, topic: 'lunch')]);
-        store.addUserTopic(stream, 'lunch', UserTopicVisibilityPolicy.muted);
+        await store.addUserTopic(stream, 'lunch', UserTopicVisibilityPolicy.muted);
         await tester.pump();
         check(tester.widgetList(find.text('lunch'))).length.equals(0);
       });
@@ -221,7 +221,7 @@ void main() {
           streams: [stream],
           subscriptions: [subscription],
           unreadMessages: [eg.streamMessage(stream: stream, topic: 'lunch')]);
-        store.addUserTopic(stream, 'lunch', UserTopicVisibilityPolicy.unmuted);
+        await store.addUserTopic(stream, 'lunch', UserTopicVisibilityPolicy.unmuted);
         await tester.pump();
         check(tester.widgetList(find.text('lunch'))).length.equals(1);
       });