pigeon: Add binding for NotificationChannel.soundUrl

Author: rajveermalviya

android/app/src/main/kotlin/com/zulip/flutter/Notifications.g.kt

@@ -62,6 +62,7 @@ data class NotificationChannel (
   val importance: Long,
   val name: String? = null,
   val lightsEnabled: Boolean? = null,
+  val soundUri: String? = null,
   val vibrationPattern: LongArray? = null
 
 ) {
@@ -72,8 +73,9 @@ data class NotificationChannel (
       val importance = __pigeon_list[1].let { num -> if (num is Int) num.toLong() else num as Long }
       val name = __pigeon_list[2] as String?
       val lightsEnabled = __pigeon_list[3] as Boolean?
-      val vibrationPattern = __pigeon_list[4] as LongArray?
-      return NotificationChannel(id, importance, name, lightsEnabled, vibrationPattern)
+      val soundUri = __pigeon_list[4] as String?
+      val vibrationPattern = __pigeon_list[5] as LongArray?
+      return NotificationChannel(id, importance, name, lightsEnabled, soundUri, vibrationPattern)
     }
   }
   fun toList(): List<Any?> {
@@ -82,6 +84,7 @@ data class NotificationChannel (
       importance,
       name,
       lightsEnabled,
+      soundUri,
       vibrationPattern,
     )
   }

android/app/src/main/kotlin/com/zulip/flutter/ZulipPlugin.kt

@@ -5,6 +5,7 @@ import android.content.ContentUris
 import android.content.ContentValues
 import android.content.Context
 import android.content.Intent
+import android.media.AudioAttributes
 import android.net.Uri
 import android.os.Build
 import android.os.Bundle
@@ -60,6 +61,10 @@ private class AndroidNotificationHost(val context: Context)
             .Builder(channel.id, channel.importance.toInt()).apply {
                 channel.name?.let { setName(it) }
                 channel.lightsEnabled?.let { setLightsEnabled(it) }
+                channel.soundUri?.let {
+                    setSound(Uri.parse(it),
+                        AudioAttributes.Builder().setUsage(AudioAttributes.USAGE_NOTIFICATION).build())
+                }
                 channel.vibrationPattern?.let { setVibrationPattern(it) }
             }.build()
         NotificationManagerCompat.from(context).createNotificationChannel(notificationChannel)

lib/host/android_notifications.g.dart

@@ -24,6 +24,7 @@ class NotificationChannel {
     required this.importance,
     this.name,
     this.lightsEnabled,
+    this.soundUri,
     this.vibrationPattern,
   });
 
@@ -39,6 +40,8 @@ class NotificationChannel {
 
   bool? lightsEnabled;
 
+  String? soundUri;
+
   Int64List? vibrationPattern;
 
   Object encode() {
@@ -47,6 +50,7 @@ class NotificationChannel {
       importance,
       name,
       lightsEnabled,
+      soundUri,
       vibrationPattern,
     ];
   }
@@ -58,7 +62,8 @@ class NotificationChannel {
       importance: result[1]! as int,
       name: result[2] as String?,
       lightsEnabled: result[3] as bool?,
-      vibrationPattern: result[4] as Int64List?,
+      soundUri: result[4] as String?,
+      vibrationPattern: result[5] as Int64List?,
     );
   }
 }

pigeon/notifications.dart

@@ -20,6 +20,7 @@ class NotificationChannel {
     required this.importance,
     this.name,
     this.lightsEnabled,
+    this.soundUri,
     this.vibrationPattern,
   });
 
@@ -33,6 +34,7 @@ class NotificationChannel {
 
   final String? name;
   final bool? lightsEnabled;
+  final String? soundUri;
   final Int64List? vibrationPattern;
 }
 

test/notifications/display_test.dart

@@ -129,6 +129,7 @@ void main() {
         ..name.equals('Messages')
         ..importance.equals(NotificationImportance.high)
         ..lightsEnabled.equals(true)
+        ..soundUri.isNull()
         ..vibrationPattern.isNotNull().deepEquals(
             NotificationChannelManager.kVibrationPattern)
       ;
@@ -1186,6 +1187,7 @@ extension NotificationChannelChecks on Subject<NotificationChannel> {
   Subject<int> get importance => has((x) => x.importance, 'importance');
   Subject<String?> get name => has((x) => x.name, 'name');
   Subject<bool?> get lightsEnabled => has((x) => x.lightsEnabled, 'lightsEnabled');
+  Subject<String?> get soundUri => has((x) => x.soundUri, 'soundUri');
   Subject<Int64List?> get vibrationPattern => has((x) => x.vibrationPattern, 'vibrationPattern');
 }