Skip to content

Commit 2789a1f

Browse files
committed
store [nfc]: Note TODOs to update more data structures on fetching messages
1 parent 6bb7f99 commit 2789a1f

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

lib/model/store.dart

+6-1
Original file line numberDiff line numberDiff line change
@@ -321,8 +321,11 @@ class PerAccountStore extends ChangeNotifier with StreamStore, MessageStore {
321321
void unregisterMessageList(MessageListView view) =>
322322
_messages.unregisterMessageList(view);
323323
@override
324-
void reconcileMessages(List<Message> messages) =>
324+
void reconcileMessages(List<Message> messages) {
325325
_messages.reconcileMessages(messages);
326+
// TODO(#649) notify [unreads] of the just-fetched messages
327+
// TODO(#650) notify [recentDmConversationsView] of the just-fetched messages
328+
}
326329

327330
final MessageStoreImpl _messages;
328331

@@ -441,6 +444,8 @@ class PerAccountStore extends ChangeNotifier with StreamStore, MessageStore {
441444
_messages.handleMessageEvent(event);
442445
unreads.handleMessageEvent(event);
443446
recentDmConversationsView.handleMessageEvent(event);
447+
// When adding anything here (to handle [MessageEvent]),
448+
// it probably belongs in [reconcileMessages] too.
444449
} else if (event is UpdateMessageEvent) {
445450
assert(debugLog("server event: update_message ${event.messageId}"));
446451
_messages.handleUpdateMessageEvent(event);

0 commit comments

Comments
 (0)