test [nfc]: Make addSubscription async

This is the next step toward making handleEvent async.

Author: gnprice

test/model/message_list_test.dart

@@ -41,7 +41,7 @@ void main() async {
     subscription = eg.subscription(stream);
     store = eg.store();
     await store.addStream(stream);
-    store.addSubscription(subscription);
+    await store.addSubscription(subscription);
     connection = store.connection as FakeApiConnection;
     notifiedCount = 0;
     model = MessageListView.init(store: store, narrow: narrow)
@@ -560,9 +560,9 @@ void main() async {
       final stream2 = eg.stream(streamId: 2, name: 'stream 2');
       await prepare(narrow: const AllMessagesNarrow());
       await store.addStreams([stream1, stream2]);
-      store.addSubscription(eg.subscription(stream1));
+      await store.addSubscription(eg.subscription(stream1));
       store.addUserTopic(stream1, 'B', UserTopicVisibilityPolicy.muted);
-      store.addSubscription(eg.subscription(stream2, isMuted: true));
+      await store.addSubscription(eg.subscription(stream2, isMuted: true));
       store.addUserTopic(stream2, 'C', UserTopicVisibilityPolicy.unmuted);
 
       // Check filtering on fetchInitial…
@@ -617,7 +617,7 @@ void main() async {
       final stream = eg.stream(streamId: 1, name: 'stream 1');
       await prepare(narrow: StreamNarrow(stream.streamId));
       await store.addStream(stream);
-      store.addSubscription(eg.subscription(stream, isMuted: true));
+      await store.addSubscription(eg.subscription(stream, isMuted: true));
       store.addUserTopic(stream, 'A', UserTopicVisibilityPolicy.unmuted);
       store.addUserTopic(stream, 'C', UserTopicVisibilityPolicy.muted);
 
@@ -661,7 +661,7 @@ void main() async {
       final stream = eg.stream(streamId: 1, name: 'stream 1');
       await prepare(narrow: TopicNarrow(stream.streamId, 'A'));
       await store.addStream(stream);
-      store.addSubscription(eg.subscription(stream, isMuted: true));
+      await store.addSubscription(eg.subscription(stream, isMuted: true));
       store.addUserTopic(stream, 'A', UserTopicVisibilityPolicy.muted);
 
       // Check filtering on fetchInitial…

test/model/stream_test.dart

@@ -54,7 +54,7 @@ void main() {
       await store.addStream(stream2);
       checkUnified(store);
 
-      store.addSubscription(eg.subscription(stream1));
+      await store.addSubscription(eg.subscription(stream1));
       checkUnified(store);
     });
   });
@@ -141,15 +141,15 @@ void main() {
       test('with policy none, stream not muted', () async {
         final store = eg.store();
         await store.addStream(stream1);
-        store.addSubscription(eg.subscription(stream1));
+        await store.addSubscription(eg.subscription(stream1));
         check(store.isTopicVisibleInStream(stream1.streamId, 'topic')).isTrue();
         check(store.isTopicVisible        (stream1.streamId, 'topic')).isTrue();
       });
 
       test('with policy none, stream muted', () async {
         final store = eg.store();
         await store.addStream(stream1);
-        store.addSubscription(eg.subscription(stream1, isMuted: true));
+        await store.addSubscription(eg.subscription(stream1, isMuted: true));
         check(store.isTopicVisibleInStream(stream1.streamId, 'topic')).isTrue();
         check(store.isTopicVisible        (stream1.streamId, 'topic')).isFalse();
       });
@@ -164,7 +164,7 @@ void main() {
       test('with policy muted', () async {
         final store = eg.store();
         await store.addStream(stream1);
-        store.addSubscription(eg.subscription(stream1));
+        await store.addSubscription(eg.subscription(stream1));
         store.addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.muted);
         check(store.isTopicVisibleInStream(stream1.streamId, 'topic')).isFalse();
         check(store.isTopicVisible        (stream1.streamId, 'topic')).isFalse();
@@ -173,7 +173,7 @@ void main() {
       test('with policy unmuted', () async {
         final store = eg.store();
         await store.addStream(stream1);
-        store.addSubscription(eg.subscription(stream1, isMuted: true));
+        await store.addSubscription(eg.subscription(stream1, isMuted: true));
         store.addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.unmuted);
         check(store.isTopicVisibleInStream(stream1.streamId, 'topic')).isTrue();
         check(store.isTopicVisible        (stream1.streamId, 'topic')).isTrue();
@@ -182,7 +182,7 @@ void main() {
       test('with policy followed', () async {
         final store = eg.store();
         await store.addStream(stream1);
-        store.addSubscription(eg.subscription(stream1, isMuted: true));
+        await store.addSubscription(eg.subscription(stream1, isMuted: true));
         store.addUserTopic(stream1, 'topic', UserTopicVisibilityPolicy.followed);
         check(store.isTopicVisibleInStream(stream1.streamId, 'topic')).isTrue();
         check(store.isTopicVisible        (stream1.streamId, 'topic')).isTrue();

test/model/test_store.dart

@@ -132,7 +132,7 @@ extension PerAccountStoreTestExtension on PerAccountStore {
     handleEvent(StreamCreateEvent(id: 1, streams: streams));
   }
 
-  void addSubscription(Subscription subscription) {
+  Future<void> addSubscription(Subscription subscription) async {
     addSubscriptions([subscription]);
   }
 

test/model/unreads_test.dart

@@ -158,9 +158,9 @@ void main() {
       final stream3 = eg.stream(streamId: 3, name: 'stream 3');
       prepare();
       await streamStore.addStreams([stream1, stream2, stream3]);
-      streamStore.addSubscription(eg.subscription(stream1));
-      streamStore.addSubscription(eg.subscription(stream2));
-      streamStore.addSubscription(eg.subscription(stream3, isMuted: true));
+      await streamStore.addSubscription(eg.subscription(stream1));
+      await streamStore.addSubscription(eg.subscription(stream2));
+      await streamStore.addSubscription(eg.subscription(stream3, isMuted: true));
       streamStore.addUserTopic(stream1, 'a', UserTopicVisibilityPolicy.muted);
       fillWithMessages([
         eg.streamMessage(stream: stream1, topic: 'a', flags: []),
@@ -178,7 +178,7 @@ void main() {
       final stream = eg.stream();
       prepare();
       await streamStore.addStream(stream);
-      streamStore.addSubscription(eg.subscription(stream));
+      await streamStore.addSubscription(eg.subscription(stream));
       streamStore.addUserTopic(stream, 'a', UserTopicVisibilityPolicy.unmuted);
       streamStore.addUserTopic(stream, 'c', UserTopicVisibilityPolicy.muted);
       fillWithMessages([

test/widgets/action_sheet_test.dart

@@ -43,7 +43,7 @@ Future<void> setupToMessageActionSheet(WidgetTester tester, {
   if (message is StreamMessage) {
     final stream = eg.stream(streamId: message.streamId);
     await store.addStream(stream);
-    store.addSubscription(eg.subscription(stream));
+    await store.addSubscription(eg.subscription(stream));
   }
   final connection = store.connection as FakeApiConnection;