notif: Replace flutter_local_notification createNotificationChannel with pigeon

Updates #351

Author: rajveermalviya

lib/notifications/display.dart

@@ -53,16 +53,14 @@ class NotificationChannelManager {
   //    channel ID and delete it.  See zulip-mobile's `createNotificationChannel`
   //    in android/app/src/main/java/com/zulipmobile/notifications/NotificationChannelManager.kt .
   static Future<void> _ensureChannel() async {
-    final plugin = ZulipBinding.instance.notifications;
-    await plugin.resolvePlatformSpecificImplementation<AndroidFlutterLocalNotificationsPlugin>()
-      ?.createNotificationChannel(AndroidNotificationChannel(
-        kChannelId,
-        'Messages', // TODO(i18n)
-        importance: Importance.high,
-        enableLights: true,
-        vibrationPattern: kVibrationPattern,
-        // TODO(#340) sound
-      ));
+    await ZulipBinding.instance.androidNotificationHost.createNotificationChannel(NotificationChannel(
+      id: kChannelId,
+      name: 'Messages', // TODO(i18n)
+      importance: NotificationImportance.high,
+      lightsEnabled: true,
+      vibrationPattern: kVibrationPattern,
+      // TODO(#340) sound
+    ));
   }
 }
 

test/model/binding.dart

@@ -4,7 +4,6 @@ import 'package:firebase_core/firebase_core.dart';
 import 'package:firebase_messaging/firebase_messaging.dart';
 import 'package:flutter/foundation.dart';
 import 'package:flutter_local_notifications/flutter_local_notifications.dart' hide Person;
-import 'package:flutter_local_notifications_platform_interface/flutter_local_notifications_platform_interface.dart';
 import 'package:test/fake.dart';
 import 'package:url_launcher/url_launcher.dart' as url_launcher;
 import 'package:zulip/host/android_notifications.dart';
@@ -513,34 +512,6 @@ class FakeFlutterLocalNotificationsPlugin extends Fake implements FlutterLocalNo
     return true;
   }
 
-  FlutterLocalNotificationsPlatform? _platform;
-
-  @override
-  T? resolvePlatformSpecificImplementation<T extends FlutterLocalNotificationsPlatform>() {
-    // This follows the logic of the base class's implementation,
-    // but supplies our fakes for the per-platform classes.
-    assert(initializationSettings != null);
-    assert(T != FlutterLocalNotificationsPlatform);
-    if (kIsWeb) return null;
-    switch (defaultTargetPlatform) {
-      case TargetPlatform.android:
-        assert(_platform == null || _platform is FakeAndroidFlutterLocalNotificationsPlugin);
-        if (T != AndroidFlutterLocalNotificationsPlugin) return null;
-        return (_platform ??= FakeAndroidFlutterLocalNotificationsPlugin()) as T?;
-
-      case TargetPlatform.iOS:
-        assert(_platform == null || _platform is FakeIOSFlutterLocalNotificationsPlugin);
-        if (T != IOSFlutterLocalNotificationsPlugin) return null;
-        return (_platform ??= FakeIOSFlutterLocalNotificationsPlugin()) as T?;
-
-      case TargetPlatform.linux:
-      case TargetPlatform.macOS:
-      case TargetPlatform.windows:
-      case TargetPlatform.fuchsia:
-        return null;
-    }
-  }
-
   /// The value to be returned by [getNotificationAppLaunchDetails].
   NotificationAppLaunchDetails? appLaunchDetails;
 
@@ -556,32 +527,21 @@ class FakeFlutterLocalNotificationsPlugin extends Fake implements FlutterLocalNo
   }
 }
 
-class FakeAndroidFlutterLocalNotificationsPlugin extends Fake implements AndroidFlutterLocalNotificationsPlugin {
+class FakeAndroidNotificationHostApi implements AndroidNotificationHostApi {
   /// Consume the log of calls made to [createNotificationChannel].
   ///
   /// This returns a list of the arguments to all calls made
   /// to [createNotificationChannel] since the last call to this method.
-  List<AndroidNotificationChannel> takeCreatedChannels() {
+  List<NotificationChannel> takeCreatedChannels() {
     final result = _createdChannels;
     _createdChannels = [];
     return result;
   }
-  List<AndroidNotificationChannel> _createdChannels = [];
+  List<NotificationChannel> _createdChannels = [];
 
   @override
-  Future<void> createNotificationChannel(AndroidNotificationChannel notificationChannel) async {
-    _createdChannels.add(notificationChannel);
-  }
-}
-
-class FakeIOSFlutterLocalNotificationsPlugin extends Fake implements IOSFlutterLocalNotificationsPlugin {
-}
-
-class FakeAndroidNotificationHostApi implements AndroidNotificationHostApi {
-  @override
-  Future<void> createNotificationChannel(NotificationChannel channel) {
-    // TODO: implement createNotificationChannel
-    throw UnimplementedError();
+  Future<void> createNotificationChannel(NotificationChannel channel) async {
+    _createdChannels.add(channel);
   }
 
   /// Consume the log of calls made to [notify].

test/notifications/display_test.dart

@@ -29,11 +29,6 @@ import '../test_navigation.dart';
 import '../widgets/message_list_checks.dart';
 import '../widgets/page_checks.dart';
 
-FakeAndroidFlutterLocalNotificationsPlugin get notifAndroid =>
-  testBinding.notifications
-    .resolvePlatformSpecificImplementation<AndroidFlutterLocalNotificationsPlugin>()
-    as FakeAndroidFlutterLocalNotificationsPlugin;
-
 MessageFcmMessage messageFcmMessage(
   Message zulipMessage, {
   String? streamName,
@@ -90,20 +85,13 @@ void main() {
   group('NotificationChannelManager', () {
     test('smoke', () async {
       await init();
-      check(notifAndroid.takeCreatedChannels()).single
+      check(testBinding.androidNotificationHost.takeCreatedChannels()).single
         ..id.equals(NotificationChannelManager.kChannelId)
         ..name.equals('Messages')
-        ..description.isNull()
-        ..groupId.isNull()
-        ..importance.equals(Importance.high)
-        ..playSound.isTrue()
-        ..sound.isNull()
-        ..enableVibration.isTrue()
+        ..importance.equals(NotificationImportance.high)
+        ..lightsEnabled.equals(true)
         ..vibrationPattern.isNotNull().deepEquals(
             NotificationChannelManager.kVibrationPattern)
-        ..showBadge.isTrue()
-        ..enableLights.isTrue()
-        ..ledColor.isNull()
       ;
     });
   });
@@ -462,19 +450,12 @@ void main() {
   });
 }
 
-extension AndroidNotificationChannelChecks on Subject<AndroidNotificationChannel> {
+extension NotificationChannelChecks on Subject<NotificationChannel> {
   Subject<String> get id => has((x) => x.id, 'id');
-  Subject<String> get name => has((x) => x.name, 'name');
-  Subject<String?> get description => has((x) => x.description, 'description');
-  Subject<String?> get groupId => has((x) => x.groupId, 'groupId');
-  Subject<Importance> get importance => has((x) => x.importance, 'importance');
-  Subject<bool> get playSound => has((x) => x.playSound, 'playSound');
-  Subject<AndroidNotificationSound?> get sound => has((x) => x.sound, 'sound');
-  Subject<bool> get enableVibration => has((x) => x.enableVibration, 'enableVibration');
-  Subject<bool> get enableLights => has((x) => x.enableLights, 'enableLights');
+  Subject<int> get importance => has((x) => x.importance, 'importance');
+  Subject<String?> get name => has((x) => x.name, 'name');
+  Subject<bool?> get lightsEnabled => has((x) => x.lightsEnabled, 'lightsEnabled');
   Subject<Int64List?> get vibrationPattern => has((x) => x.vibrationPattern, 'vibrationPattern');
-  Subject<Color?> get ledColor => has((x) => x.ledColor, 'ledColor');
-  Subject<bool> get showBadge => has((x) => x.showBadge, 'showBadge');
 }
 
 extension on Subject<AndroidNotificationHostApiNotifyCall> {