notif [nfc]: Remove unused AndroidIntent.extras

Author: rajveermalviya

android/app/src/main/kotlin/com/zulip/flutter/Notifications.g.kt

@@ -99,7 +99,6 @@ data class NotificationChannel (
 data class AndroidIntent (
   val action: String,
   val dataUrl: String,
-  val extras: Map<String?, String?>,
   /** A combination of flags from [IntentFlag]. */
   val flags: Long
 
@@ -109,16 +108,14 @@ data class AndroidIntent (
     fun fromList(__pigeon_list: List<Any?>): AndroidIntent {
       val action = __pigeon_list[0] as String
       val dataUrl = __pigeon_list[1] as String
-      val extras = __pigeon_list[2] as Map<String?, String?>
-      val flags = __pigeon_list[3].let { num -> if (num is Int) num.toLong() else num as Long }
-      return AndroidIntent(action, dataUrl, extras, flags)
+      val flags = __pigeon_list[2].let { num -> if (num is Int) num.toLong() else num as Long }
+      return AndroidIntent(action, dataUrl, flags)
     }
   }
   fun toList(): List<Any?> {
     return listOf(
       action,
       dataUrl,
-      extras,
       flags,
     )
   }

android/app/src/main/kotlin/com/zulip/flutter/ZulipPlugin.kt

@@ -104,7 +104,6 @@ private class AndroidNotificationHost(val context: Context)
                         context,
                         MainActivity::class.java
                     ).apply {
-                        intent.extras.forEach { (k, v) -> putExtra(k!!, v!!) }
                         flags = intent.flags.toInt()
                     } },
                     it.flags.toInt())

lib/host/android_notifications.g.dart

@@ -72,24 +72,20 @@ class AndroidIntent {
   AndroidIntent({
     required this.action,
     required this.dataUrl,
-    required this.extras,
     this.flags = 0,
   });
 
   String action;
 
   String dataUrl;
 
-  Map<String?, String?> extras;
-
   /// A combination of flags from [IntentFlag].
   int flags;
 
   Object encode() {
     return <Object?>[
       action,
       dataUrl,
-      extras,
       flags,
     ];
   }
@@ -99,8 +95,7 @@ class AndroidIntent {
     return AndroidIntent(
       action: result[0]! as String,
       dataUrl: result[1]! as String,
-      extras: (result[2] as Map<Object?, Object?>?)!.cast<String?, String?>(),
-      flags: result[3]! as int,
+      flags: result[2]! as int,
     );
   }
 }

lib/notifications/display.dart

@@ -196,7 +196,6 @@ class NotificationDisplayManager {
         intent: AndroidIntent(
           action: IntentAction.view,
           dataUrl: intentDataUrl.toString(),
-          extras: {},
           // See these sections in the Android docs:
           //   https://developer.android.com/guide/components/activities/tasks-and-back-stack#TaskLaunchModes
           //   https://developer.android.com/reference/android/content/Intent#FLAG_ACTIVITY_CLEAR_TOP

pigeon/notifications.dart

@@ -42,11 +42,10 @@ class NotificationChannel {
 ///   https://developer.android.com/reference/android/content/Intent
 ///   https://developer.android.com/reference/android/content/Intent#Intent(java.lang.String,%20android.net.Uri,%20android.content.Context,%20java.lang.Class%3C?%3E)
 class AndroidIntent {
-  AndroidIntent({required this.action, required this.dataUrl, required this.extras, this.flags = 0});
+  AndroidIntent({required this.action, required this.dataUrl, this.flags = 0});
 
   final String action;
   final String dataUrl;
-  final Map<String?, String?> extras;
 
   /// A combination of flags from [IntentFlag].
   final int flags;

test/notifications/display_test.dart

@@ -286,7 +286,6 @@ void main() {
               ..intent.which((it) => it
                 ..action.equals(IntentAction.view)
                 ..dataUrl.equals(expectedIntentDataUrl.toString())
-                ..extras.deepEquals({})
                 ..flags.equals(expectedIntentFlags))),
           (it) => it.isA<AndroidNotificationHostApiNotifyCall>()
             ..id.equals(NotificationDisplayManager.notificationIdAsHashOf(expectedGroupKey))
@@ -1219,7 +1218,6 @@ extension on Subject<PendingIntent> {
 extension on Subject<AndroidIntent> {
   Subject<String> get action => has((x) => x.action, 'action');
   Subject<String> get dataUrl => has((x) => x.dataUrl, 'dataUrl');
-  Subject<Map<String?, String?>> get extras => has((x) => x.extras, 'extras');
   Subject<int> get flags => has((x) => x.flags, 'flags');
 }