autocomplete: Sort user-mention autocomplete results

sm-sayedi · sm-sayedi · commit 78b0bb160bbc · 2024-05-14T14:21:06.000+04:30
In @-mention autocomplete, users are suggested based on: 1. Recent activity in the current stream. 2. Recent DM conversations. 3. Human vs. Bot users. 4. Alphabetical order. Fixes: #228
diff --git a/lib/model/autocomplete.dart b/lib/model/autocomplete.dart
@@ -295,7 +295,12 @@ class MentionAutocompleteView extends ChangeNotifier {
     } else if (userA.isBot && !userB.isBot) {
       return 1;
     }
-    return 0;
+
+    final userAName = store.autocompleteViewManager.autocompleteDataCache
+      .normalizedNameForUser(userA);
+    final userBName = store.autocompleteViewManager.autocompleteDataCache
+      .normalizedNameForUser(userB);
+    return userAName.compareTo(userBName);
   }
 
   List<User> sortByRelevance({

Original file line number	Diff line number	Diff line change
`@@ -295,7 +295,12 @@ class MentionAutocompleteView extends ChangeNotifier {`
`295`	`295`	`} else if (userA.isBot && !userB.isBot) {`
`296`	`296`	`return 1;`
`297`	`297`	`}`
`298`		`- return 0;`
	`298`	`+`
	`299`	`+ final userAName = store.autocompleteViewManager.autocompleteDataCache`
	`300`	`+ .normalizedNameForUser(userA);`
	`301`	`+ final userBName = store.autocompleteViewManager.autocompleteDataCache`
	`302`	`+ .normalizedNameForUser(userB);`
	`303`	`+ return userAName.compareTo(userBName);`
`299`	`304`	`}`
`300`	`305`
`301`	`306`	`List<User> sortByRelevance({`