Skip to content

Commit 85b9c43

Browse files
gnpricechrisbobbe
authored andcommitted
api: Cut ChannelPropertyName.canRemoveSubscribersGroup
This is affected by the same root cause as #1082, though the impact here is much smaller: this one only applies to an event at the moment someone edits one of these settings.
1 parent 48fb81b commit 85b9c43

File tree

6 files changed

+2
-16
lines changed

6 files changed

+2
-16
lines changed

lib/api/model/events.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -439,9 +439,6 @@ class ChannelUpdateEvent extends ChannelEvent {
439439
return value as int?;
440440
case ChannelPropertyName.channelPostPolicy:
441441
return ChannelPostPolicy.fromApiValue(value as int);
442-
case ChannelPropertyName.canRemoveSubscribersGroup:
443-
case ChannelPropertyName.canRemoveSubscribersGroupId:
444-
return value as int;
445442
case ChannelPropertyName.streamWeeklyTraffic:
446443
return value as int?;
447444
case null:

lib/api/model/events.g.dart

Lines changed: 0 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/api/model/model.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -388,8 +388,8 @@ enum ChannelPropertyName {
388388
messageRetentionDays,
389389
@JsonValue('stream_post_policy')
390390
channelPostPolicy,
391-
canRemoveSubscribersGroup,
392-
canRemoveSubscribersGroupId, // TODO(server-8): remove, replaced by canRemoveSubscribersGroup
391+
// canRemoveSubscribersGroup, // TODO(#814)
392+
// canRemoveSubscribersGroupId, // TODO(#814) handle // TODO(server-8) remove
393393
streamWeeklyTraffic;
394394

395395
/// Get a [ChannelPropertyName] from a raw, snake-case string we recognize, else null.

lib/api/model/model.g.dart

Lines changed: 0 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/model/channel.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -279,9 +279,6 @@ class ChannelStoreImpl with ChannelStore {
279279
stream.messageRetentionDays = event.value as int?;
280280
case ChannelPropertyName.channelPostPolicy:
281281
stream.channelPostPolicy = event.value as ChannelPostPolicy;
282-
case ChannelPropertyName.canRemoveSubscribersGroup:
283-
case ChannelPropertyName.canRemoveSubscribersGroupId:
284-
break; // not tracking this property
285282
case ChannelPropertyName.streamWeeklyTraffic:
286283
stream.streamWeeklyTraffic = event.value as int?;
287284
}

test/example_data.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -786,8 +786,6 @@ ChannelUpdateEvent channelUpdateEvent(
786786
assert(value is int?);
787787
case ChannelPropertyName.channelPostPolicy:
788788
assert(value is ChannelPostPolicy);
789-
case ChannelPropertyName.canRemoveSubscribersGroup:
790-
case ChannelPropertyName.canRemoveSubscribersGroupId:
791789
case ChannelPropertyName.streamWeeklyTraffic:
792790
assert(value is int?);
793791
}

0 commit comments

Comments
 (0)