Skip to content

Commit f76b003

Browse files
PIG208gnprice
authored andcommitted
compose test [nfc]: Rename param from user to otherUsers
Signed-off-by: Zixuan James Li <[email protected]>
1 parent 9e5f803 commit f76b003

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

test/widgets/compose_box_test.dart

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ void main() {
4444
Future<void> prepareComposeBox(WidgetTester tester, {
4545
required Narrow narrow,
4646
User? selfUser,
47-
List<User> users = const [],
47+
List<User> otherUsers = const [],
4848
List<ZulipStream> streams = const [],
4949
}) async {
5050
if (narrow case ChannelNarrow(:var streamId) || TopicNarrow(: var streamId)) {
@@ -58,7 +58,7 @@ void main() {
5858

5959
store = await testBinding.globalStore.perAccount(selfAccount.id);
6060

61-
await store.addUsers([selfUser, ...users]);
61+
await store.addUsers([selfUser, ...otherUsers]);
6262
await store.addStreams(streams);
6363
connection = store.connection as FakeApiConnection;
6464

@@ -746,15 +746,15 @@ void main() {
746746
testWidgets('compose box replaced with a banner', (tester) async {
747747
final deactivatedUser = eg.user(isActive: false);
748748
await prepareComposeBox(tester, narrow: dmNarrowWith(deactivatedUser),
749-
users: [deactivatedUser]);
749+
otherUsers: [deactivatedUser]);
750750
checkComposeBox(isShown: false);
751751
});
752752

753753
testWidgets('active user becomes deactivated -> '
754754
'compose box is replaced with a banner', (tester) async {
755755
final activeUser = eg.user(isActive: true);
756756
await prepareComposeBox(tester, narrow: dmNarrowWith(activeUser),
757-
users: [activeUser]);
757+
otherUsers: [activeUser]);
758758
checkComposeBox(isShown: true);
759759

760760
await changeUserStatus(tester, user: activeUser, isActive: false);
@@ -765,7 +765,7 @@ void main() {
765765
'banner is replaced with the compose box', (tester) async {
766766
final deactivatedUser = eg.user(isActive: false);
767767
await prepareComposeBox(tester, narrow: dmNarrowWith(deactivatedUser),
768-
users: [deactivatedUser]);
768+
otherUsers: [deactivatedUser]);
769769
checkComposeBox(isShown: false);
770770

771771
await changeUserStatus(tester, user: deactivatedUser, isActive: true);
@@ -777,15 +777,15 @@ void main() {
777777
testWidgets('compose box replaced with a banner', (tester) async {
778778
final deactivatedUsers = [eg.user(isActive: false), eg.user(isActive: false)];
779779
await prepareComposeBox(tester, narrow: groupDmNarrowWith(deactivatedUsers),
780-
users: deactivatedUsers);
780+
otherUsers: deactivatedUsers);
781781
checkComposeBox(isShown: false);
782782
});
783783

784784
testWidgets('at least one user becomes deactivated -> '
785785
'compose box is replaced with a banner', (tester) async {
786786
final activeUsers = [eg.user(isActive: true), eg.user(isActive: true)];
787787
await prepareComposeBox(tester, narrow: groupDmNarrowWith(activeUsers),
788-
users: activeUsers);
788+
otherUsers: activeUsers);
789789
checkComposeBox(isShown: true);
790790

791791
await changeUserStatus(tester, user: activeUsers[0], isActive: false);
@@ -796,7 +796,7 @@ void main() {
796796
'banner is replaced with the compose box', (tester) async {
797797
final deactivatedUsers = [eg.user(isActive: false), eg.user(isActive: false)];
798798
await prepareComposeBox(tester, narrow: groupDmNarrowWith(deactivatedUsers),
799-
users: deactivatedUsers);
799+
otherUsers: deactivatedUsers);
800800
checkComposeBox(isShown: false);
801801

802802
await changeUserStatus(tester, user: deactivatedUsers[0], isActive: true);

0 commit comments

Comments
 (0)