Handle moved messages (update_message events, 2/2) #150
Assignees
Labels
Milestone
Comments
gnprice
added
a-api
77 tasks
This was referenced Jun 18, 2024
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
Jun 21, 2024
When a channel (a.k.a stream) or a topic gets updated on a message, we get a UpdateMessageEvent from the server. This updates the edit state to show the "edited" or "moved" marker properly on the messages affected, and leave other move related states (like streamId) untouched until we get to zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
Jun 21, 2024
When a channel (a.k.a stream) or a topic gets updated on a message, we get a UpdateMessageEvent from the server. This updates the edit state to show the "edited" or "moved" marker properly on the messages affected, and leave other move related states (like streamId) untouched until we get to zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
Jun 21, 2024
When a channel (a.k.a stream) or a topic gets updated on a message, we get a UpdateMessageEvent from the server. The same happens when the message's content is updated. This updates the edit state to show the "edited" or "moved" marker properly on the messages affected, and leave other move related states (like streamId) untouched until we get to zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
Jun 22, 2024
When a channel (a.k.a stream) or a topic gets updated on a message, we get a UpdateMessageEvent from the server. The same happens when the message's content is updated. This updates the edit state to show the "edited" or "moved" marker properly on the messages affected, and leave other move related states (like streamId) untouched until we get to zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
Jun 25, 2024
When a channel (a.k.a stream) or a topic gets updated on a message, we get a UpdateMessageEvent from the server. The same happens when the message's content is updated. This updates the edit state to show the "edited" or "moved" marker properly on the messages affected, and leave other move related states (like streamId) untouched until we get to zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
Jun 25, 2024
When a channel (a.k.a stream) or a topic gets updated on a message, we get a UpdateMessageEvent from the server. The same happens when the message's content is updated. This updates the edit state to show the "edited" or "moved" marker properly on the messages affected, and leave other move related states (like streamId) untouched until we get to zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
Jun 25, 2024
When a channel (a.k.a stream) or a topic gets updated on a message, we get a UpdateMessageEvent from the server. The same happens when the message's content is updated. This updates the edit state to show the "edited" or "moved" marker properly on the messages affected, and leave other move related states (like streamId) untouched until we get to zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
Jun 25, 2024
When a channel (a.k.a stream) or a topic gets updated on a message, we get a UpdateMessageEvent from the server. The same happens when the message's content is updated. This updates the edit state to show the "edited" or "moved" marker properly on the messages affected, and leave other move related states (like streamId) untouched until we get to zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
Jun 25, 2024
When a channel (a.k.a stream) or a topic gets updated on a message, we get a UpdateMessageEvent from the server. The same happens when the message's content is updated. This updates the edit state to show the "edited" or "moved" marker properly on the messages affected, and leave other move related states (like streamId) untouched until we get to zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
Jun 26, 2024
When a channel (a.k.a stream) or a topic gets updated on a message, we get a UpdateMessageEvent from the server. The same happens when the message's content is updated. This updates the edit state to show the "edited" or "moved" marker properly on the messages affected, and leave other move related states (like streamId) untouched until we get to zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
Jun 26, 2024
When a channel (a.k.a stream) or a topic gets updated on a message, we get a UpdateMessageEvent from the server. The same happens when the message's content is updated. This updates the edit state to show the "edited" or "moved" marker properly on the messages affected, and leave other move related states (like streamId) untouched until we get to zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
Jun 26, 2024
When a channel (a.k.a stream) or a topic gets updated on a message, we get a UpdateMessageEvent from the server. The same happens when the message's content is updated. This updates the edit state to show the "edited" or "moved" marker properly on the messages affected, and leave other move related states (like streamId) untouched until we get to zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
Jun 26, 2024
When a channel (a.k.a stream) or a topic gets updated on a message, we get a UpdateMessageEvent from the server. The same happens when the message's content is updated. This updates the edit state to show the "edited" or "moved" marker properly on the messages affected, and leave other move related states (like streamId) untouched until we get to zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
2 tasks
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
Jun 27, 2024
When a channel (a.k.a stream) or a topic gets updated on a message, we get a UpdateMessageEvent from the server. The same happens when the message's content is updated. This updates the edit state to show the "edited" or "moved" marker properly on the messages affected, and leave other move related states (like streamId) untouched until we get to zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
Jun 27, 2024
When a channel (a.k.a stream) or a topic gets updated on a message, we get a UpdateMessageEvent from the server. The same happens when the message's content is updated. This updates the edit state to show the "edited" or "moved" marker properly on the messages affected, and leave other move related states (like streamId) untouched until we get to zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to PIG208/zulip-flutter
that referenced
this issue
Jun 27, 2024
When a channel (a.k.a stream) or a topic gets updated on a message, we get a UpdateMessageEvent from the server. The same happens when the message's content is updated. This updates the edit state to show the "edited" or "moved" marker properly on the messages affected, and leave other move related states (like streamId) untouched until we get to zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Jul 26, 2024
We only implement navigation change for the TopicNarrow. For StreamNarrow, propagateMode is practically unused. See also: zulip/zulip-mobile#5251 Fixes: zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Jul 26, 2024
We only implement navigation change for the TopicNarrow. For StreamNarrow, propagateMode is practically unused. See also: zulip/zulip-mobile#5251 Fixes: zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Jul 26, 2024
We only implement navigation change for the TopicNarrow. For StreamNarrow, propagateMode is practically unused. See also: zulip/zulip-mobile#5251 Fixes: zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Jul 26, 2024
We only implement navigation change for the TopicNarrow. For StreamNarrow, propagateMode is practically unused. See also: zulip/zulip-mobile#5251 Fixes: zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
|
This will be mostly covered by #787. But after that lands, we should follow up with a quick scan to identify anything else that needs updating on message moves — there are several new data structures in the store that we've merged in recent weeks. |
PIG208
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Jul 27, 2024
We only implement navigation change for the TopicNarrow. For StreamNarrow, propagateMode is practically unused. See also: zulip/zulip-mobile#5251 Fixes: zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Jul 29, 2024
We only implement navigation change for the TopicNarrow. For StreamNarrow, propagateMode is practically unused. See also: zulip/zulip-mobile#5251 Fixes: zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Jul 29, 2024
We only implement navigation change for the TopicNarrow. For StreamNarrow, propagateMode is practically unused. See also: zulip/zulip-mobile#5251 Fixes: zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Jul 29, 2024
We only implement navigation change for the TopicNarrow. For StreamNarrow, propagateMode is practically unused. See also: zulip/zulip-mobile#5251 Fixes: zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Jul 29, 2024
We only implement navigation change for the TopicNarrow. For StreamNarrow, propagateMode is practically unused. See also: zulip/zulip-mobile#5251 Fixes: zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Jul 29, 2024
We only implement navigation change for the TopicNarrow. For StreamNarrow, propagateMode is practically unused. See also: zulip/zulip-mobile#5251 Fixes: zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Jul 29, 2024
We only implement navigation change for the TopicNarrow. For StreamNarrow, propagateMode is practically unused. See also: zulip/zulip-mobile#5251 Fixes: zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Jul 29, 2024
We only implement navigation change for the TopicNarrow. For StreamNarrow, propagateMode is practically unused. See also: zulip/zulip-mobile#5251 Fixes: zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Jul 30, 2024
We only implement navigation change for the TopicNarrow. For StreamNarrow, propagateMode is practically unused. See also: zulip/zulip-mobile#5251 Fixes: zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Jul 30, 2024
We only implement navigation change for the TopicNarrow. For StreamNarrow, propagateMode is practically unused. See also: zulip/zulip-mobile#5251 Fixes: zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Jul 30, 2024
We only implement navigation change for the TopicNarrow. For StreamNarrow, propagateMode is practically unused. See also: zulip/zulip-mobile#5251 Fixes: zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Jul 30, 2024
We only implement navigation change for the TopicNarrow. For StreamNarrow, propagateMode is practically unused. See also: zulip/zulip-mobile#5251 Fixes: zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Jul 31, 2024
We only implement navigation change for the TopicNarrow. For StreamNarrow, propagateMode is practically unused. See also: zulip/zulip-mobile#5251 Fixes: zulip#150. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Aug 2, 2024
Navigation change is only intended for TopicNarrow. For StreamNarrow, propagateMode is unused. See also: zulip/zulip-mobile#5251 Fixes: zulip#150 Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Aug 2, 2024
Navigation change is only intended for TopicNarrow. For StreamNarrow, propagateMode is unused. See also: - zulip/zulip-mobile#5251 - zulip#787 (comment) Fixes: zulip#150 Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Aug 2, 2024
Navigation change is only intended for TopicNarrow. For StreamNarrow, propagateMode is unused. See also: - zulip/zulip-mobile#5251 - zulip#787 (comment) Fixes: zulip#150 Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Aug 2, 2024
Navigation change is only intended for TopicNarrow. For StreamNarrow, propagateMode is unused. See also: - zulip/zulip-mobile#5251 - zulip#787 (comment) Fixes: zulip#150 Signed-off-by: Zixuan James Li <[email protected]>
PIG208
added a commit
to gnprice/zulip-flutter
that referenced
this issue
Aug 9, 2024
Navigation change is only intended for TopicNarrow. For StreamNarrow, propagateMode is unused. See also: - zulip/zulip-mobile#5251 - zulip#787 (comment) Fixes: zulip#150 Signed-off-by: Zixuan James Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://zulip.com/api/get-events#update_message
This issue is for the case where the messages were moved to a different stream or topic. (The case where a message's content changed is #118.)
In particular these should be handled in the MessageListView view-model, so that the message disappears from the view if it no longer belongs in that particular narrow, or appears if it newly does belong.
The text was updated successfully, but these errors were encountered: