Skip to content

Better title group DMs in Android notifications #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rajveermalviya opened this issue Jul 8, 2024 · 1 comment
Open

Better title group DMs in Android notifications #794

rajveermalviya opened this issue Jul 8, 2024 · 1 comment
Labels
a-Android Issues specific to Android, or requiring Android-specific work a-notifications
Milestone

Comments

@rajveermalviya
Copy link
Member

rajveermalviya commented Jul 8, 2024

In group DMs, the Android notification's conversation title currently displays only the latest sender's display name, such as "from Greg Price with 1 other".

Instead, it should name the other recipients too, up to 3 names (and excluding self). Beyond that, it should name 3 of the members of the thread and use the "N others" form for the rest, as in "Alice, Bob, Carol, and 2 others".

The difficulty here is that while for the message's sender, the server includes their display name (and avatar URL), for the other recipients we have just their user IDs but no details like display names. There are two options for how we could handle this:

  • We could have the server start including it in notification payloads. That'd start working promptly for users on Zulip Cloud and other servers regularly updated from Git. We'd fall back to the current text when it's not available.
    • This isn't ideal because it involves denormalizing more and more data into the notification payloads. But it would be easy to do.
  • We could start keeping the list of users, including their names, in the database so that we have it ready when a notification arrives.
    • We'll want to do this eventually for the sake of Have data ready on app startup #477.
    • This is something we won't do soon, though, because it'll involve adding significant new complexity where we update data on server events. That's worth it for Have data ready on app startup #477, because that's a major improvement to the UX, but is too much for this issue to justify.

Corresponding zulip-mobile issue: zulip/zulip-mobile#5116

@gnprice
Copy link
Member

gnprice commented Jul 8, 2024

Thanks for filing this! I revised the description, including taking more text from zulip/zulip-mobile#5116 .

@gnprice gnprice added the a-Android Issues specific to Android, or requiring Android-specific work label Jul 8, 2024
@gnprice gnprice modified the milestones: M6: Post-launch, M7: Future Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-Android Issues specific to Android, or requiring Android-specific work a-notifications
Projects
Status: No status
Development

No branches or pull requests

2 participants