Skip to content

Commit 78daeb6

Browse files
committed
deps: Add typescript as dev dependency.
We don't need TypeScript ourselves [1], but we want to upgrade `eslint-plugin-jest` soon, and a rather distant dependency has a peer dependency of TypeScript (as we also saw in 01593b3). Here's the output: ``` warning "eslint-plugin-jest > @typescript-eslint/experimental-utils > @typescript-eslint/typescript-estree > [email protected]" has unmet peer dependency "typescript@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta". ``` Ah well, at least we can put it in `devDependencies`. And `yarn why typescript` reveals that `prettier-eslint` and `prettier-eslint-cli` have both already been bringing it in as their dependency. Those libraries are using version 3.9.7, so we set the range to include that version, so we can avoid pulling in a new copy. [1] #3458 is open to consider migrating from Flow to TypeScript, but that's not what this commit is about.
1 parent 974b325 commit 78daeb6

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,7 @@
137137
"react-native-cli": "^2.0.1",
138138
"redux-mock-store": "^1.5.1",
139139
"rollup": "^2.26.5",
140+
"typescript": "^3.9.7",
140141
"yarn-deduplicate": "^1.1.1"
141142
}
142143
}

yarn.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9818,7 +9818,7 @@ typescript-compiler@^1.4.1-2:
98189818
resolved "https://registry.yarnpkg.com/typescript-compiler/-/typescript-compiler-1.4.1-2.tgz#ba4f7db22d91534a1929d90009dce161eb72fd3f"
98199819
integrity sha1-uk99si2RU0oZKdkACdzhYety/T8=
98209820

9821-
typescript@^3.2.1, typescript@^3.4, typescript@^3.9.3:
9821+
typescript@^3.2.1, typescript@^3.4, typescript@^3.9.3, typescript@^3.9.7:
98229822
version "3.9.7"
98239823
resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.9.7.tgz#98d600a5ebdc38f40cb277522f12dc800e9e25fa"
98249824
integrity sha512-BLbiRkiBzAwsjut4x/dsibSTB6yWpwT5qWmC2OfuCg3GgVQCSgMs4vEctYPhsaGtd0AeuuHMkjZ2h2WG8MSzRw==

0 commit comments

Comments
 (0)