-
Notifications
You must be signed in to change notification settings - Fork 39
[1/x] Add Wasm component translation support to the integration tests #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7bc8936
to
c46ca5d
Compare
5252664
to
30cb7dd
Compare
@bitwalker I'd like |
72bf0d3
to
30cb7dd
Compare
I think that should be fine. One thing I'm considering is whether or not to switch to an s-expr representation like Wasm, to make it easier to maintain and extend, and to keep the parser dead simple - but until that happens, I think this is likely to be the only unambiguous way to represent components in the textual format.
I think we should use attributes for metadata items like the |
I got back to this PR to add curly braces, and I don't know why I have not replied to this earlier, but I like the s-expr idea very much. Admittedly, after staring into WAT for so long, I find it very readable. |
fe0cbde
to
2d39974
Compare
@greenhat I think we'll want to reimplement these changes on #149 since we'll need to port the changes over anyway. Since the PR updates all of the tests, all that is really needed are the new IR components, implementing the formatting using In any case, PR looks good otherwise, so if you are cool with me refactoring it for you, I'll go ahead and do that |
Sure. I appreciate it if you'd take care of that. Thanks. |
components and Miden SDK tests. The panic handler and global allocator is now set in the `lib.rs` file of each component crate. Before, the `cargo-component-bindings` was not built correctly for `no_std` and was linking the stdlib allocator. The Rust bindings for the WIT are now generated in the `src` directory of the component crate, instead of the `target/.../bindings` directory. The Wasm `bulk-memory` proposal is enabled via `RUSTFLAGS` so that `memcpy` function import is replaced with Wasm `memory.copy` op.
2d39974
to
1960cfd
Compare
Add Wasm component translation support to
CompileTest
.Add a text representation of the IR
Component
and use it in the expected tests.