Skip to content

feat: switch to stable vm, link against real miden-lib #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

bitwalker
Copy link
Contributor

No description provided.

@bitwalker bitwalker requested a review from greenhat May 15, 2025 22:39
@bitwalker bitwalker added codegen Issues or features related to lowering IR into MASM blocker This issue is one of our top priorities build Build or CI-related tasks and improvements labels May 15, 2025
Copy link
Contributor

@greenhat greenhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!


semver = { version = "1.0", default-features = false }
[patch.crates-io]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@@ -23,8 +22,6 @@ use crate::{

pub static STDLIB: LazyLock<Arc<CompiledLibrary>> =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably ditch STDLIB in favor of StdLibrary::default().as_ref().clone() as well for consistency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I'll do that before merging!

Base automatically changed from emit-trace-events to next May 19, 2025 16:50
@bitwalker bitwalker force-pushed the bitwalker/switch-to-real-miden-lib branch from fd3b295 to 0216c52 Compare May 20, 2025 17:45
@bitwalker bitwalker merged commit 210f930 into next May 20, 2025
7 checks passed
@bitwalker bitwalker deleted the bitwalker/switch-to-real-miden-lib branch May 20, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker This issue is one of our top priorities build Build or CI-related tasks and improvements codegen Issues or features related to lowering IR into MASM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants