Skip to content

Adding ConfigClass for HTTPX #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 2, 2025
Merged

Conversation

mattjacksoncello
Copy link
Contributor

This PR is to implement a config class to allow more control over httpx for things like certificate verification.

I have also merged in the changes from #92

Note: I have used Claude to help with the changes. I have reviewed everything but I am not the strongest coder so there may be mistakes that I have missed

Copy link

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

@mattjacksoncello
Copy link
Contributor Author

Thanks for the review Andy, will refactor the code

@mattjacksoncello
Copy link
Contributor Author

@AndyTitu,

I've updated the PR to focus solely on the config class changes as requested. Here are the key updates:

  1. Documentation:

    • Added a new section in USAGE.md documenting the primary use case for CA certificate verification with Connect server
  2. Testing:

    • Created a new test file specifically for the config class implementation
    • Looking for feedback on test coverage and potential edge cases
  3. Examples:

    • Added a new example demonstrating CA file usage in practice

Please review these changes and let me know if any adjustments are needed.

@mattjacksoncello mattjacksoncello marked this pull request as ready for review January 29, 2025 22:04
@mattjacksoncello
Copy link
Contributor Author

Hi @AndyTitu

Any updates on this?

Thanks

@mattjacksoncello
Copy link
Contributor Author

Hi @AndyTitu
When do you think you will have time to review this? I would like to use the production version if possible.
Thanks

@AndyTitu
Copy link
Contributor

AndyTitu commented Mar 4, 2025

@mattjacksoncello apologies for missing notifications on this. I'm on it now.

Copy link
Contributor

@AndyTitu AndyTitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me apart from some small suggestions, thank you for the contribution! ❤️

@AndyTitu
Copy link
Contributor

AndyTitu commented Mar 5, 2025

@mattjacksoncello some tests are failing for the last changes.

@mattjacksoncello
Copy link
Contributor Author

Hi Andy,
I have renamed all instances of cafile to ca_file. Test are now working
Cheers!

@mattjacksoncello
Copy link
Contributor Author

@AndyTitu Could you have another look at this please

@mattjacksoncello
Copy link
Contributor Author

@AndyTitu Can you review this please

@AndyTitu AndyTitu merged commit 3fba133 into 1Password:main Jun 2, 2025
1 check passed
@mattjacksoncello
Copy link
Contributor Author

Hi @AndyTitu
when will this be integrated into a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants