Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update electron to v32 #7525

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

arthuro555
Copy link
Contributor

@arthuro555 arthuro555 commented Apr 1, 2025

Closes #6530

This update is long due, this update shouldn't require deep changes to GDevelop, and only needed minor updates to a few dependencies.
I picked v32 instead of latest as there are changes to native modules in v33 that might have more unpredictable impacts on desktop builds.

Tested the IDE, tested making and running a manual build of a test project with the steamworks extension. Everything seems to work.

@arthuro555 arthuro555 requested a review from 4ian as a code owner April 1, 2025 10:55
@4ian
Copy link
Owner

4ian commented Apr 3, 2025

Thanks for doing this! I'll launch an experimental build to see if we can test built versions on multiple systems.

@arthuro555
Copy link
Contributor Author

Hmm.... The build errors are because the ubuntu version of the CI is too old and doesn't bundle gcc with c++ 20 support :/
I had not updated to the latest version of electron precisely to avoid these troubles, but I guess electron-builder already adopted the requirement too 😓

That means that the one-click packaging service probably also will need to be updated and tested for c++ 20 support before shipping this update!

@arthuro555
Copy link
Contributor Author

(We probably should wait before updating electron more still though, as there are other breaking changes with worrying implications in v33)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Electron 18.x.y has reached end-of-support
2 participants