Skip to content
This repository was archived by the owner on Aug 28, 2023. It is now read-only.

Closes #150: Render missing signers in summary #155

Merged
merged 8 commits into from
Sep 30, 2020

Conversation

rmeissner
Copy link
Member

@rmeissner rmeissner commented Sep 28, 2020

  • Render missing signers for transactions that are waiting for confirmation
  • missing_signers is not rendered at all for transactions that are not waiting for confirmation

@rmeissner rmeissner self-assigned this Sep 28, 2020
@coveralls
Copy link

coveralls commented Sep 28, 2020

Pull Request Test Coverage Report for Build 380

  • 177 of 186 (95.16%) changed or added relevant lines in 5 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.6%) to 78.748%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/models/converters/transactions/summary.rs 12 13 92.31%
src/models/converters/transactions/tests/summary.rs 85 93 91.4%
Files with Coverage Reduction New Missed Lines %
src/models/converters/transactions/mod.rs 1 73.37%
src/models/converters/transactions/tests/summary.rs 2 55.34%
Totals Coverage Status
Change from base Build 365: 0.6%
Covered Lines: 2416
Relevant Lines: 3068

💛 - Coveralls

@rmeissner rmeissner merged commit e871feb into main Sep 30, 2020
@rmeissner rmeissner deleted the feature/issue_150_missing_confirmations branch September 30, 2020 13:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include information to check whose signatures are missing in summary item
3 participants