Remove bindgen float16 workaround #3166
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes two lines from
libafl_qemu_build/src/bindings.rs
that define the existence of libclang headersavx512vlfp16intrin.h
andavx512fp16intrin.h
.This used to be a workaround for bindgen not working well with specific types defined in Clang's
mmintrin.h
, see rust-lang/rust-bindgen#2500 (comment).This seems to have been resolved in rust-lang/rust-bindgen#2667, pushed to bindgen
v0.69.3
, rendering the workaround unnecessary.With the old workaround, I was not able to compile libafl_qemu on clang-19 and later. See the build error below.
I tested this PR, and libafl_qemu compiles properly with clang-13, clang-15, and clang-19 to clang-21.
Clang 21 error message
Checklist
./scripts/precommit.sh
and addressed all comments