Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Qwen3 models.
Basically, the implementation is highly similar to llama2 except qk_norm so I just added
use_qk_norm
. Also, I addedquery_pre_attn_scalar
which ishead_dim ** 0.5
as llama4.maxtext/MaxText/layers/qwen3.py
Lines 106 to 107 in f4a5e24
FIXES: #1834
Checklist
Before submitting this PR, please make sure (put X in square brackets):