Get Linter / CPU tests to succeed

[SamuelMarks]

Description

Recommend not merging changes in future that don't pass the CI linting check.

Tests

N/A

Checklist

Before submitting this PR, please make sure (put X in square brackets):

• I have performed a self-review of my code.
• I have necessary comments in my code, particularly in hard-to-understand areas.
• I have run end-to-end tests tests and provided workload links above if applicable.
• I have made or will make corresponding changes to the doc if needed.

[bvandermoon]

Thanks Samuel. Just a few questions on the specific lint rules here

Just for my understanding - how are you finding these lint issues? Are these just rules we have disabled and you are planning to turn them back on?

[SamuelMarks]

Thanks Samuel. Just a few questions on the specific lint rules here

Just for my understanding - how are you finding these lint issues? Are these just rules we have disabled and you are planning to turn them back on?

Thanks for reviewing

Here I just ran bash code_style.sh and added one # pylint: disable=arguments-differ manually

FWIW: The lints should all be enabled now except for R0401,R0917,W0201,W0613, see https://github.com/AI-Hypercomputer/maxtext/blob/69ffd34/.github/workflows/CPUTests.yml#L39

[bvandermoon]

Thanks Samuel. Just a few questions on the specific lint rules here
Just for my understanding - how are you finding these lint issues? Are these just rules we have disabled and you are planning to turn them back on?

Thanks for reviewing

Here I just ran bash code_style.sh and added one # pylint: disable=arguments-differ manually

FWIW: The lints should all be enabled now except for R0401,R0917,W0201,W0613, see https://github.com/AI-Hypercomputer/maxtext/blob/69ffd34/.github/workflows/CPUTests.yml#L39

Awesome, makes sense. Thanks @SamuelMarks

[SamuelMarks]

FYI: Latest push was due to merge conflict so I just reran bash code_style.sh on the fresh HEAD