migrate wayland-rs to 0.31 #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjc7373
commented
Nov 3, 2023
| poll.poll(&mut events, None).expect("Failed to poll fds"); | ||
| for event in &events { | ||
| match event.token() { | ||
| STATE_CHANGE => { |
There was a problem hiding this comment.
I wonder why do we need to send heartbeat if some state changes? I personally want the watcher to ignore the fluctuations when I switch windows very quickly..
There was a problem hiding this comment.
No need, it just makes the tracking more accurate. Essentially it makes the tracking almost perfect instead of approximate.
Considering how cheap it is to make a heartbeat, I found it to be a nice feature for barely any cost.
|
I recommend that you implement this instead of kwin-idle |
|
Sure, if this PR can be accepted, I definitely want to implement that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major refactor and not finished yet.. But it's workable under sway and I think it's time to get some feedback.
Basically we need to implement a
Dispatchtrait for every event. There's macrodelegate_noopto ignore irrelevant events.Also wayland-protocols-wlr and wayland-protocols-plasma crate offer the interfaces we need, so there's no need to generate some bindings manually.