Improve description of partiness modifiers #681
+15
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview was deployed to: https://pull-request-681.kb-adg.pages.dev/ |
slavaleleka
approved these changes
Apr 15, 2025
el-termikael
approved these changes
Apr 21, 2025
| @@ -742,6 +742,8 @@ Rules with the `$popup` modifier are not supported by AdGuard Content Blocker. | |||
|
|
|||
| Works the same as the [`$~third-party`](#third-party-modifier) modifier, but only treats the request as first-party if the referrer and origin have exactly the same hostname. | |||
|
|
|||
| Requests without referrer are also treated as first-party requests and the rules with `$strict-first-party` modifier will be applied to such requests. | |||
There was a problem hiding this comment.
Suggested change
| Requests without referrer are also treated as first-party requests and the rules with `$strict-first-party` modifier will be applied to such requests. | |
| Requests without a referrer are also treated as first-party requests, and the rules with the `$strict-first-party` modifier are applied to such requests. |
| @@ -756,6 +758,8 @@ You can use a shorter name (alias) instead of using the full modifier name: `$st | |||
|
|
|||
| Rules with the `$strict-first-party` modifier are supported by AdGuard for Windows, AdGuard for Mac, and AdGuard for Android with [CoreLibs] v1.16 or later. | |||
|
|
|||
| Requests without referrer are matched by rules with `$strict-first-party` in Adguard for Windows, AdGuard for Mac and AdGuard for Android with [CoreLibs] v1.18 or later. | |||
There was a problem hiding this comment.
Suggested change
| Requests without referrer are matched by rules with `$strict-first-party` in Adguard for Windows, AdGuard for Mac and AdGuard for Android with [CoreLibs] v1.18 or later. | |
| Requests without a referrer are matched by rules with `$strict-first-party` in AdGuard for Windows, AdGuard for Mac, and AdGuard for Android with [CoreLibs] v1.18 or later. |
| @@ -795,20 +799,28 @@ To be considered as such, a third-party request should meet one of the following | |||
|
|
|||
| **`$third-party`:** | |||
|
|
|||
| - `||domain.com^$third-party` — this rule applies to all domains, except `domain.com` and its subdomains. An example of a third-party request: `http://example.org/banner.jpg`. | |||
| - `||domain.com^$third-party` — this rule applies to all domains, except `domain.com` and its subdomains. The rule will never be applied if there is not referrer. An example of a third-party request: `http://example.org/banner.jpg`. | |||
There was a problem hiding this comment.
Suggested change
| - `||domain.com^$third-party` — this rule applies to all domains, except `domain.com` and its subdomains. The rule will never be applied if there is not referrer. An example of a third-party request: `http://example.org/banner.jpg`. | |
| - `||domain.com^$third-party` — this rule applies to all domains except `domain.com` and its subdomains. The rule is never applied if there is no referrer. An example of a third-party request: `http://example.org/banner.jpg`. |
|
|
||
| If there is a `$~third-party` modifier, the rule is only applied to the requests that are not from third parties. Which means, they have to be sent from the same domain. | ||
| If there is a `$~third-party` modifier, the rule is only applied to the requests that are not from third parties. Which means, they have to be sent from the same domain or shouldn't have referrer at all. |
There was a problem hiding this comment.
Suggested change
| If there is a `$~third-party` modifier, the rule is only applied to the requests that are not from third parties. Which means, they have to be sent from the same domain or shouldn't have referrer at all. | |
| If there is a `$~third-party` modifier, the rule is only applied to requests that are not from third parties. Which means they have to be sent from the same domain or shouldn't have a referrer at all. |
|
|
||
| **`$~third-party`:** | ||
|
|
||
| - `||domain.com$~third-party` — this rule is applied exclusively to `domain.com`. Example of a non third-party request: `http://domain.com/icon.ico`. | ||
| - `||domain.com$~third-party` — this rule is applied exclusively to `domain.com` and its subdomains. Example of a non third-party request: `http://sub.domain.com/icon.ico`. |
There was a problem hiding this comment.
Suggested change
| - `||domain.com$~third-party` — this rule is applied exclusively to `domain.com` and its subdomains. Example of a non third-party request: `http://sub.domain.com/icon.ico`. | |
| - `||domain.com$~third-party` — this rule applies only to `domain.com` and its subdomains. Example of a non third-party request: `http://sub.domain.com/icon.ico`. |
| - `||domain.com$~third-party` — this rule is applied exclusively to `domain.com`. Example of a non third-party request: `http://domain.com/icon.ico`. | ||
| - `||domain.com$~third-party` — this rule is applied exclusively to `domain.com` and its subdomains. Example of a non third-party request: `http://sub.domain.com/icon.ico`. | ||
|
|
||
| Requests without referrer are also treated as non-third-party requests and the rules with `$~third-party` modifier will be applied to such requests. |
There was a problem hiding this comment.
Suggested change
| Requests without referrer are also treated as non-third-party requests and the rules with `$~third-party` modifier will be applied to such requests. | |
| Requests without a referrer are also treated as non third-party requests and the rules with the `$~third-party` modifier are applied to such requests. |
|
|
||
| :::note | ||
|
|
||
| You may use a shorter name (alias) instead of using the full modifier name: `$3p`. | ||
|
|
||
| ::: | ||
|
|
||
| :::info Compatibility | ||
|
|
||
| Requests without referrer are matched by rules with `$~third-party` in Adguard for Windows, AdGuard for Mac and AdGuard for Android with [CoreLibs] v1.18 or later. |
There was a problem hiding this comment.
Suggested change
| Requests without referrer are matched by rules with `$~third-party` in Adguard for Windows, AdGuard for Mac and AdGuard for Android with [CoreLibs] v1.18 or later. | |
| Requests without a referrer are matched by rules with `$strict-first-party` in AdGuard for Windows, AdGuard for Mac, and AdGuard for Android with [CoreLibs] v1.18 or later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target CoreLibs version is 1.18