Sagemaker ModelLifeCycle bug: TypeError: Object of type ModelLifeCycle is not JSON serializable #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
Add unit test to verify ModelLifeCycle object integration with model.register() method. The test ensures proper dictionary conversion and parameter passing when registering models with lifecycle metadata.
|
Resolves #3 |
|
To provide feedback, navigate to the Files changed tab and leave comments on the proposed code changes. Choose Start review for each comment, and then choose Request changes, and I'll propose revised changes. |
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
✅ I finished the code review, and didn't find any security or code quality issues. |
Aditi2424
added
the
Amazon Q development agent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for ModelLifeCycle functionality in SageMaker. The key addition is a new test file that verifies the model registration process can properly handle ModelLifeCycle objects, which help track and manage the stages of a model's lifecycle (like Development, Staging, Production etc.).
The changes appear to be focused on:
The core changes involve verifying that ModelLifeCycle objects are correctly converted to the expected dictionary format when registering models, ensuring proper tracking of model stages and status throughout their lifecycle.
This enhancement provides better model governance and tracking capabilities in the SageMaker SDK.