Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search engine feature #7262

Open
wants to merge 266 commits into
base: main
Choose a base branch
from

Conversation

adityasoni9998
Copy link
Contributor

@adityasoni9998 adityasoni9998 commented Mar 14, 2025

This PR adds a search engine feature to OpenHands.

Changes:

  1. Add search engine tool to codeact agent
  2. Add search action and observation types
  3. Add tests for search engine feature

Tests:

  • Added test_get_tools_with_options to verify search engine tool is enabled/disabled correctly
  • Added test_search_engine_tool to verify tool schema
  • Added test_response_to_actions_search_engine to verify action creation from tool calls

Fix: #7262

adityasoni9998 and others added 30 commits January 27, 2025 18:41
…sary (All-Hands-AI#6618)

Co-authored-by: openhands <openhands@all-hands.dev>
Co-authored-by: openhands <openhands@all-hands.dev>
Co-authored-by: Xingyao Wang <xingyao6@illinois.edu>
…dates (All-Hands-AI#6617)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: amanape <83104063+amanape@users.noreply.github.com>
Co-authored-by: sp.wack <83104063+amanape@users.noreply.github.com>
Co-authored-by: openhands <openhands@all-hands.dev>
Co-authored-by: Ray Myers <ray.myers@gmail.com>
@neubig
Copy link
Contributor

neubig commented Mar 17, 2025

@OpenHands please do the following:

  1. check the diff with the base branch and all the PR comments to fully understand what is going on here
  2. reflect all review comments and also solve all merge conflicts with main
  3. double check that the PR is limited to only relevant changes, and doesn't make other extraneous changes
  4. reflect all the review comments
  5. run each of the steps in the py-unit-tests.yml workflow to make sure that tests are passing

Copy link

openhands-ai bot commented Mar 17, 2025

Openhands is working, @neubig can track my progress at all-hands.dev

@neubig neubig changed the title Support for using Search Engines in OpenHands via API Calls Add search engine feature Mar 17, 2025
@neubig
Copy link
Contributor

neubig commented Mar 17, 2025

@OpenHands add user-facing documentation of this feature. It should be included in the "Advanced Configuration" section of the docs. Please view other pages in that section and understand the structure and content of other similar docs, then add some docs for this feature. You can keep it concise, no need to be overly wordy.

Copy link

openhands-ai bot commented Mar 17, 2025

Openhands is working, @neubig can track my progress at all-hands.dev

@BradKML
Copy link

BradKML commented Apr 2, 2025

What is the current progress with this and search engines (e.g. SearXNG or Startpage or Qwant)?

@xingyaoww
Copy link
Collaborator

@BradKML I think this PR itself is working.. The reason we haven't merge this is that this adds yet another potential env var we need to worry about (i.e., SEARCH ENGINE API KEY) that may complicate the user experience (user need to input yet another key to use OpenHands) OR the developer experience (if we want to automatically turn off search IF user didn't provide the key).

I'm thinking if this can be taken care of by the MCP (#7637) that will give us search engine & other things, and we can just implement these "selective turn off when no API key is provided" in one place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet