Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: "start from scratch" button results in a "no query provided" error #7622

Closed
wants to merge 1 commit into from

Conversation

neubig
Copy link
Contributor

@neubig neubig commented Apr 1, 2025

Description

This PR fixes issue #7621 where clicking the "start from scratch" button on the hero page results in a "no query provided" toast error.

Changes

  • Added an allowEmptyQuery parameter to the useCreateConversation hook to allow empty queries when explicitly starting from scratch
  • Updated the CodeNotInGitHubLink component to use the new parameter
  • Added tests to verify the fix works correctly

Fixes #7621

@neubig can click here to continue refining the PR


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:d6935e3-nikolaik   --name openhands-app-d6935e3   docker.all-hands.dev/all-hands-ai/openhands:d6935e3

@neubig neubig marked this pull request as draft April 1, 2025 15:21
@neubig neubig self-assigned this Apr 1, 2025
@neubig
Copy link
Contributor Author

neubig commented Apr 6, 2025

I have not been able to reproduce this error recently, so I assume it's fixed now

@neubig neubig closed this Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: "start from scratch" button results in a "no query provided" error
2 participants