-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix export conversation button in Safari #7662
base: main
Are you sure you want to change the base?
Conversation
…ers without File System Access API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this, it's been bugging me!
Can't wait to try it. 🥳
Do you think we can merge this? We have a report on the button doing nothing, though I'm not sure what browser were they using. |
Yeah, should be able to merge it. Was stuck with some issues with the dummy agent tests I couldn't sort out (but those are no longer blocking). |
Ah yes, and we're removing it. |
Description
This PR fixes the issue with the "export conversation" button not working in Safari browsers.
Problem
The current implementation uses the File System Access API (
showSaveFilePicker
), which is not supported in Safari. This causes the export functionality to fail silently in Safari browsers.Solution
Implemented a fallback mechanism that uses the traditional download method (
downloadJSON
) when the File System Access API is not available. This ensures that the export functionality works across all browsers, including Safari.Changes
downloadTrajectory
function to check for browser support and use appropriate download methoddownloadJSON
for browsers that do not support File System Access APITo run this PR locally, use the following command: