Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retry on retryable httpx-related error to improve evaluation stability #7719

Merged
merged 15 commits into from
Apr 6, 2025
Merged

fix: retry on retryable httpx-related error to improve evaluation stability #7719

Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f17c973
fix(llm): retry on InternalServerError and Timeout; handle Gemini ret…
xingyaoww Apr 4, 2025
10d4077
Update openhands/llm/llm.py
xingyaoww Apr 4, 2025
77a43ef
Update openhands/llm/llm.py
xingyaoww Apr 4, 2025
d04b240
Fix AttributeError in LLM class when accessing resp.choices as a dict
openhands-agent Apr 4, 2025
9521c36
add special exception for llm no response error
xingyaoww Apr 4, 2025
066a898
try handle LLM No Response Error
xingyaoww Apr 4, 2025
7f92fec
Add tests for LLMNoResponseError retry decorator
openhands-agent Apr 4, 2025
7a4c455
change to .warning
xingyaoww Apr 4, 2025
4d9a696
Update retry decorator to only change temperature when it's zero
openhands-agent Apr 4, 2025
e439fb6
increase temperature to 1.0
xingyaoww Apr 4, 2025
8b204da
fix llm retry temperature
xingyaoww Apr 4, 2025
271e049
stop logging kwargs
xingyaoww Apr 4, 2025
a275efc
action execution retry on retryable httpx error
xingyaoww Apr 5, 2025
1134352
revert unrelated files
xingyaoww Apr 5, 2025
4301467
Merge branch 'main' into xw/fix-eval-retry
xingyaoww Apr 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions openhands/runtime/impl/action_execution/action_execution_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
from openhands.utils.tenacity_stop import stop_if_should_exit


def _is_retryable_check_alive_error(exception):
def _is_retryable_error(exception):
return isinstance(
exception, (httpx.RemoteProtocolError, httpcore.RemoteProtocolError)
)
Expand Down Expand Up @@ -93,6 +93,11 @@ def __init__(
def _get_action_execution_server_host(self) -> str:
pass

@retry(
retry=retry_if_exception(_is_retryable_error),
stop=stop_after_attempt(5) | stop_if_should_exit(),
wait=wait_exponential(multiplier=1, min=4, max=15),
)
def _send_action_server_request(
self,
method: str,
Expand All @@ -114,11 +119,6 @@ def _send_action_server_request(
"""
return send_request(self.session, method, url, **kwargs)

@retry(
retry=retry_if_exception(_is_retryable_check_alive_error),
stop=stop_after_attempt(5) | stop_if_should_exit(),
wait=wait_exponential(multiplier=1, min=4, max=15),
)
def check_if_alive(self) -> None:
response = self._send_action_server_request(
'GET',
Expand Down