-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #7147: Document Logging #7737
base: main
Are you sure you want to change the base?
Conversation
docs/modules/usage/logging.md
Outdated
|
||
## Security Features | ||
|
||
### SensitiveDataFilter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@openhands-agent Use the GitHub API to read the diff of this PR, PR 7737, and the issue it fixes.
The PR contents look correct, however SensitiveDataFilter is an older implementation that masks sensitive values in logs. Recently, we have implemented another way, using set_secrets() in stream.py. Read it, follow its use to understand it.
Then update this documentation with your conclusions. Does it fully replace this one? How can users make use of that one, if there's any way?
Keep it clear and to the point. No bragging or fluff, this is technical documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Openhands fix success summary
The changes successfully address the feedback by making several concrete improvements to the logging documentation:
-
Added comprehensive documentation about the newer
set_secrets()
implementation from stream.py, including:- Clear example code showing how to use it
- Explanation of how it replaces exact matches with
<secret_hidden>
- Description of its more precise control compared to pattern matching
-
Restructured the sensitive data section to show both approaches:
- Renamed section to "Sensitive Data Protection" to encompass both methods
- Clearly separated and labeled both approaches
- Maintained the existing SensitiveDataFilter documentation while adding the new content
-
Added practical guidance on when to use each approach:
- SensitiveDataFilter for general protection
- set_secrets() for precise control over specific values
-
Kept the documentation technical and concise, avoiding unnecessary language while providing the essential information users need to understand and implement either approach.
The changes directly fulfill the feedback's request to document both implementations while explaining their respective uses, maintaining technical accuracy and clarity throughout.
Based on the provided changes, it appears that OpenHands has successfully addressed all the major documentation issues regarding sensitive data handling. Here's a concise assessment: ✅ Successfully Resolved:
🔍 No apparent remaining issues to address. The changes appear to provide a complete solution that effectively documents both implementations while maintaining clarity and technical accuracy. Users now have clear guidance on when and how to use each approach for sensitive data protection. |
This pull request fixes #7147.
The issue has been successfully resolved. The changes directly address all requirements from the original issue by:
docs/modules/usage/logging.md
that covers all requested environment variables:Including detailed documentation about the SensitiveDataFilter functionality, which was specifically requested in the issue.
Adding the logging documentation to the sidebar navigation in
sidebars.ts
, making it accessible within the documentation structure.The documentation goes beyond the minimum requirements by providing:
The changes provide a complete, well-structured documentation of OpenHands' logging system, fully addressing the original request for documentation of the logging behavior and related concepts.
Automatic fix generated by OpenHands 🙌
To run this PR locally, use the following command: