[Backport] SF_OperationPowerSpectrum: Fix average option with SweepBrowser data #2419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since fd5ee28 (SF: Use correct LNB getter in SF_GetTraceColor, 2024-10-04) we require mapIndex to be valid when fetching the labnotebook for sweep data in SF_GetTraceColor. But average data was always treated sweep-like but that does not have a map index. This can also be not easily fixed as it is not clear which mapIndex to use for sweeps from multiple experiments. Instead we now use the default average color. This also makes the metadata entry SF_META_AVERAGED_FIRST_SWEEP obsolete.
t-b
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will merge once CI is passed and #2417 is merged.