SweepFormula: Groups multiple x-axis labels #2423
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The returned wave is the same as was passed in. Although the current code makes it clear what is input and what is output, this creates verbose code as you can't have the same wave as input (RHS) and output (LHS) of an equation. So let's drop the returned wave.
And rename them to emphasize the label component as the y data unit is only the fallback.
In e26f03a (SF: Adapt logic how x-waves are mapped to y-waves, 2022-08-19) we added code to special case x/y wave mapping. But we don't need to do that if we have single point x and y waves only.
This preserves wave metadata like units.
We also now always enclose units in parantheses.
t-b
force-pushed
the
bugfix/2423-sweepformula-multiple-axis-labels-for-x-axis
branch
from
86a73e9 to
74a8ffd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an enhancement/fix requested in #2362.